Fixes for the differences between CA vs old style tests

Fix a few differences observed during the comparison of fast chain test with CA-based and old style config. Some more differences still to be understood.

@jchapman, @golling, @lmijovic

added 1 commit

• f2d3ba3a - better setting of NumberOfCollisions

Compare with previous version

marked this merge request as ready

This merge request affects 3 packages:

• Simulation/Digitization
• Simulation/FastSimulation/FastChainPileup
• Tools/FullChainTransforms

Affected files list will not be printed in this case

Adding @jchapman as watcher

added Digitization Simulation Tools master review-pending-level-1 labels

CI Result FAILURE (hash f2d3ba3a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39665]

Hi @tadej , NumberOfCollisions was 0 (default) with pile-up test using CA-based config. That fixed the issue. Cheers, Tulay

added review-user-action-required label and removed review-pending-level-1 label

added NewConfig label

Hi @tadej,

https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Simulation/Digitization/python/DigitizationConfigFlags.py#0167 was called before the config lock in FastChain configuration. pileupRunArgsToFlags does not include the NumberOfCollisions. The other option would be to introduce in NumberOfCollisons in pileupRunArgsToFlags ? What do you think ?

Cheers, Tulay

But you have to setup the actual pile-up profile. And this has to be done before you lock. It's on purpose the default value here is 0, to make sure that the profile is actually properly set-up.

Which one is the actual pile-up profile ?

I guess you mean "from Digitization.PileUpUtils import setupPileUpProfile" ?

Yes, see here: https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Simulation/SimuJobTransforms/python/HITtoRDO_Skeleton.py#0065

yes, that is what I found. But it does not work. The test I am using: !46839 (5df1ea8b) and I get raise ValueError('Bunch structure and pile-up profile need to be set')

Are you sure you actually run the old-style skeleton with pile-up? Do you have a default profile set somewhere? In normal digitisation pile-up profile is always specified in a preInclude.

yes, we have nightly pile-up test running with old-style. I don't think we have default profile. @jchapman - do you have any idea for the default profile for this test ?

added 1 commit

• 0b60a39f - fix FC config

Compare with previous version

This merge request affects 2 packages:

• Simulation/FastSimulation/FastChainPileup
• Tools/FullChainTransforms

Affected files list will not be printed in this case

Adding @jchapman as watcher

added review-pending-level-1 label and removed review-user-action-required label