Dropped GeoLArHit

The benefits coming from the usage of this class are rather questionable. On the other hand, it uses AthenaMT-unfriendly way of retrieving a pointer to the CaloDetDescrManager and caching it.

The clients of GeoLArHit had been switched to the direct usage of LArHit and CaloDetDescrManager interfaces, and subsequently, the GeoLArHit class was dropped.

The migration of individual client classes were implemented in separate commits in order to facilitate the code review.

Jobs restarted after the interruption caused by urgent Jenkins maintenance

Jenkins please retry a build

This merge request affects 6 packages:

• DetectorDescription/GeoModel/GeoAdaptors
• LArCalorimeter/LArG4/LArG4Validation
• Simulation/G4Atlas/G4AtlasTests
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/Tools/CaloSamplingFractionAnalysis
• Simulation/Tools/HitAnalysis

Affected files list will not be printed in this case

Adding @jchapman ,@pjacka ,@mfauccig ,@stavrop ,@pavol ,@xiaozhon ,@jojungge ,@ahasib ,@tadej ,@schaarsc ,@rbianchi as watchers

added Geometry JetEtmiss LAr Simulation master review-pending-level-1 labels

CI Result FAILURE (hash 1abc7907)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39852]

Jenkins please retry a build

This merge request affects 6 packages:

• DetectorDescription/GeoModel/GeoAdaptors
• LArCalorimeter/LArG4/LArG4Validation
• Simulation/G4Atlas/G4AtlasTests
• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimParametrization
• Simulation/Tools/CaloSamplingFractionAnalysis
• Simulation/Tools/HitAnalysis

Affected files list will not be printed in this case

Adding @jchapman ,@pjacka ,@mfauccig ,@stavrop ,@pavol ,@xiaozhon ,@jojungge ,@ahasib ,@tadej ,@schaarsc ,@rbianchi as watchers

CI Result SUCCESS (hash 1abc7907)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39875]

resolved all threads

resolved all threads

Looks good for L1. Approved

Sergei L1

added review-approved label and removed review-pending-level-1 label

mentioned in commit f11bdad3

merged

added sweep:ignore label