Switched LArHitsTestTool to reading CaloDetDescrManager from the Detector Store

This patch is required for fixing failed ART test, which broke because of the latest update in LArHitsTestTool. In the long term, though, we need to revisit the CaloDetDescrManager usage patterns in Simulation in order to determine whether it is really needed to construct it by the converter at initialization.

Fixes ATLASSIM-5432

changed the description

This merge request affects 1 package:

• Simulation/G4Atlas/G4AtlasTests

This merge request affects 2 files:

• Simulation/G4Atlas/G4AtlasTests/src/LArHitsTestTool.cxx
• Simulation/G4Atlas/G4AtlasTests/src/LArHitsTestTool.h

Adding @jchapman as watcher

There were multiple CI triggers for this MR and commit. The system ignored duplicates. However the GitLab pipelines status may be shown incorrectly.

added Simulation master review-pending-level-1 labels

added bugfix label

CI Result SUCCESS (hash 5dd08e40)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 39964]

Looks good. Approved

Sergei L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 88b6d006

added sweep:ignore label

mentioned in merge request !47007 (merged)