Fix SysListDumperAlg

Fix SysListDumperAlg after SystematicsSvc migration. SystematicsSvc has to be used directly as SysListHandle now requires inputs and/or systematics tools to be present. Also ability to filter systematics is restored.

Technically the code was using the SystematicsSvc already through SysListHandle, it just wasn't using any functionality of the handle itself, so it makes sense to get rid of it.

/cc @krumnack @jburr @mmuskinj

added bugfix + 1 deleted label

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/SystematicsHandles

Affected files list will not be printed in this case

Adding @krumnack ,@tadej ,@pagessin as watchers

added 21.2 Analysis analysis-review-required review-pending-level-1 labels

Two CI jobs are triggered by 21.2 MR events: for AthDerivation with gcc62 compiler and with gcc8 for AnalysisBase and AthAnalysis projects.

• Developers and shifters need to wait for both results, sometimes for additional hour or two.

CI Result FAILURE (hash d032cd3e)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 1, warnings 35
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40166]

There is a build error:

In file included from input_line_8:86:
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/21.2/PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms/AsgAnalysisAlgorithms/SysListDumperAlg.h:38:57: error: no matching constructor for initialization of 'ServiceHandle<CP::ISystematicsSvc>'
    ServiceHandle<ISystematicsSvc> m_systematicsService {this, "systematicsService", "SystematicsSvc", ""};

-- L1

added review-user-action-required label and removed review-pending-level-1 label

CI Result FAILURE (hash d032cd3e)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 1, warnings 191
For experts only: Jenkins output [CI-MERGE-REQUEST-GCC62-CC7 1094]

added 1 commit

• 1db13067 - Fix SysListDumperAlg

Compare with previous version

added 1 commit

• 18a1a37b - Fix SysListDumperAlg

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/SystematicsHandles

Affected files list will not be printed in this case

Adding @krumnack ,@tadej ,@pagessin as watchers

added review-pending-level-1 label and removed review-user-action-required label

Two CI jobs are triggered by 21.2 MR events: for AthDerivation with gcc62 compiler and with gcc8 for AnalysisBase and AthAnalysis projects.

• Developers and shifters need to wait for both results, sometimes for additional hour or two.

CI Result SUCCESS (hash 18a1a37b)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40207]

Looks good. Approved

Sergei L1

added review-approved label and removed review-pending-level-1 label

CI Result SUCCESS (hash 18a1a37b)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-GCC62-CC7 1103]

changed the description