Skip to content

TriggerConfig: drop legacy menu services

Frank Winklmeier requested to merge fwinkl/athena:run3jsonmenu into master

This MR is the first step in cleaning up the legacy trigger services configuration. For default workflows we are only supporting the JSON-converted menu, which means we can use almost the same setup for Run-1&2 and Run-3 data. Further cleanup (and full CA-migration) will follow in separate MRs.

Changes to TriggerConfigGetter:

Move the creation and configuration of the JSON conversion for old data into TrigConfigSvcCfg. Remove the setup of the legacy configuration services and streamline the configuration of the Run-1&2 and Run-3 setup.

Fixes the duplicate menus in StoreGate reported in ATR-24199.

Changes to TriggerConfigFlags:

  • Delete the following obsolete flags:
    • Trigger.doConfigVersionConversion
    • Trigger.menuVersion
    • Trigger.LVL1ConfigFile
    • Trigger.L1MenuFile
    • Trigger.HLTMenuFile
    • Trigger.generateHLTMenu
  • put unit tests conditionally under __main__

Also align the default JSON output files names of TrigConfReadWrite with what we currently use in the menu generation from python.

cc @tamartin @rbielski @mark

Edited by Frank Winklmeier

Merge request reports