Added ITkCaloExtension config

This MR adds a new ITk-specific configuration for the CaloExtensionBuilder. With respect to the Run-3 configuration, it uses the new ITkExtrapolatorCfg instead of the AtlasExtrapolatorCfg. It also feeds dummy DetEleCollKey introduced due to https://its.cern.ch/jira/browse/ATLASRECTS-4688 for compatibility with TP converters but likely not relevant for Run-4 configuration.

FYI @tadej @npetters @nstyles @pagessin @lgagnon

added Calorimeter ITk NewConfig Reconstruction Tracking labels

This merge request affects 2 packages:

• Reconstruction/RecJobTransforms
• Reconstruction/RecoTools/TrackToCalo

Affected files list will not be printed in this case

Adding @goetz as watcher

added Egamma master review-pending-level-1 labels

Will ask @christos here: Do we still need those dummy DetEleCollKey ReadCondHandleKeys? It seems they are not initialised so I wonder if scheduler actually takes them into account.

You mean the dummy ones added by Susumu for the ESD workloads due to the T/P ?

ithm who wants to read tracks from ESD/AOD has to load SCT conditions (leading to the same extra >code being added all over the place). It would make more sense that is loaded once centrally, but >as you say its not possible in the P/T convertors.

For the ESD workloads I think is up to @mhodgkin as it was not me that introduced them. I hope they are not needed at large by now. There was a discussion I think back then.

Btw: In reality we seem not to have a simple ExtrapolationCfg that actually one really can configure still? So is the plan to have like ITK/Muon/Common/egamma specific ones here?

Not sure what is going on for this instance. Most of the times I see the initialize but not in this instance , @ssnyder is there a default "initialize" that could happen implicitly (? we have this for tool retrieve so I guess the default could be to propagate).

Anyhow prb we should be trying to remove these. They are there for ESD based test if I recall . And should all be "dummy" we do not use them in the relevant code (retrieve them or anything), they were just added to make sure the Trk::Track converters can run before for ESD tests.

[https://acode-browser1.usatlas.bnl.gov/lxr/ident?_i=m_SCTDetEleCollKey] @tsulaia @mnowak @mhodgkin . Do we need the dummy one since e.g they seem not to be in the T/P converters these days? [https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/InnerDetector/InDetEventCnv/InDetEventTPCnv/InDetEventTPCnv/SCT_ClusterContainerCnv_p3.h]

CI Result SUCCESS (hash a0911259)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40254]

The scheduler should still see the dependencies even if initialize() isn't called (but you won't be able to actually use the key later).

resolved all threads

I'm not sure if we need them anymore or not, if it can be done centrally somehow I agree that is better (but presumably there is a reason we did not do that?)

Cheers,

Mark

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

Approving -- L1

added review-approved label and removed review-user-action-required label

resolved all threads

mentioned in commit ac697a5d

merged

added sweep:ignore label