From e29963606c5b85f8b8aabccaa352036570b05f79 Mon Sep 17 00:00:00 2001
From: scott snyder <snyder@bnl.gov>
Date: Tue, 12 Oct 2021 16:08:43 +0200
Subject: [PATCH 1/2] MuonMM_CnvTools: Fix clang warning.
Unchecked Statuscode.
---
.../MuonCnv/MuonMM_CnvTools/src/MM_RawDataProviderToolCore.cxx | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MuonSpectrometer/MuonCnv/MuonMM_CnvTools/src/MM_RawDataProviderToolCore.cxx b/MuonSpectrometer/MuonCnv/MuonMM_CnvTools/src/MM_RawDataProviderToolCore.cxx
index d166f6da9f30..2a3e9b264996 100644
--- a/MuonSpectrometer/MuonCnv/MuonMM_CnvTools/src/MM_RawDataProviderToolCore.cxx
+++ b/MuonSpectrometer/MuonCnv/MuonMM_CnvTools/src/MM_RawDataProviderToolCore.cxx
@@ -32,7 +32,7 @@ StatusCode Muon::MM_RawDataProviderToolCore::convertIntoContainer(const std::vec
{
// Loop on the passed ROB fragments, and call the decoder for each one to fill the RDO container.
for (const ROBFragment* fragment : vecRobs)
- StatusCode st = m_decoder->fillCollection(*fragment, rdoIdhVect, mmRdoContainer); // always returns StatusCode::SUCCESS
+ ATH_CHECK( m_decoder->fillCollection(*fragment, rdoIdhVect, mmRdoContainer) ); // always returns StatusCode::SUCCESS
ATH_MSG_DEBUG("Size of mmRdoContainer is " << mmRdoContainer.size());
return StatusCode::SUCCESS;
--
GitLab
From d5e0e16502003438bcb644d1a7b6c8ff32b59836 Mon Sep 17 00:00:00 2001
From: scott snyder <snyder@bnl.gov>
Date: Tue, 12 Oct 2021 16:09:38 +0200
Subject: [PATCH 2/2] MuonSTGC_CnvTools: Fix clang warning.
Unchecked StatusCode.
---
.../MuonSTGC_CnvTools/src/STGC_RawDataProviderToolCore.cxx | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools/src/STGC_RawDataProviderToolCore.cxx b/MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools/src/STGC_RawDataProviderToolCore.cxx
index a63d5a8bbd89..52c6bd9e754b 100644
--- a/MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools/src/STGC_RawDataProviderToolCore.cxx
+++ b/MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools/src/STGC_RawDataProviderToolCore.cxx
@@ -30,10 +30,8 @@ StatusCode Muon::STGC_RawDataProviderToolCore::convertIntoContainer(const std::v
{
// Loop on the passed ROB fragments, and call the decoder for each one to fill the RDO container.
- static std::atomic_int DecodeErrCount{0};
-
for (const ROBFragment* fragment : vecRobs)
- StatusCode st = m_decoder->fillCollection(*fragment, rdoIdhVect, stgcRdoContainer); // always returns StatusCode::SUCCESS
+ ATH_CHECK( m_decoder->fillCollection(*fragment, rdoIdhVect, stgcRdoContainer) ); // always returns StatusCode::SUCCESS
ATH_MSG_DEBUG("Size of sTgcRdoContainer is " << stgcRdoContainer.size());
return StatusCode::SUCCESS;
--
GitLab