TrigT2CaloCommon: Cleaning up LArCablingLegacyService.

Pass LArFebRodMapping to Hid2RESrcId, so that we can get rid of the methods relying on the obsolete LArCablingLegacyService.

Pass LArRoI_Map to LArCellCont, rather than having the latter retrieve it again. Makes dependencies more explicit.

This merge request affects 1 package:

• Trigger/TrigAlgorithms/TrigT2CaloCommon

This merge request affects 3 files:

• Trigger/TrigAlgorithms/TrigT2CaloCommon/TrigT2CaloCommon/LArCellCont.h
• Trigger/TrigAlgorithms/TrigT2CaloCommon/src/LArCellCont.cxx
• Trigger/TrigAlgorithms/TrigT2CaloCommon/src/TrigCaloDataAccessSvc.cxx

Adding @joheinri ,@damazio as watchers

added Trigger master review-pending-level-1 labels

Thanks a lot Scott, for doing this. Exactly as I would do.. Hope this is the last change we needed here to remove Legacies.. Best, Denis

CI Result SUCCESS (hash fc5ae1d3)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40275]

Approving -- L1

added review-approved label and removed review-pending-level-1 label

hi Denis -

There will be one more change coming here to completely remove references to LArLegacyCablingService / LArRoI_Map, but need a few other upstream changes first.

merged

mentioned in commit e07d3be7

added sweep:ignore label