Add extra triggers for DF-level PHYS(LITE) matching [ATR-24269]

After requesting feedback from trigger groups on the available triggers for matching DAOD_PHYS we found some missing ones. Many of these fall into categories that would not naturally be returned by the trigger API (e.g. prescaled or rerun triggers) so it's easiest for us to hardcode these lists as data files. As these are very simple I've just opted for a basic text file, but allowing comments to make the structure clearer.

I've checked that this results in new triggers added to the DAOD, however I have not been able to check that the rerun triggers work correctly as we apparently do not have files with those available. If someone knows of such a file I'm happy to check that this has actually worked.

Tagging @tamartin, @jcatmore for info

added 1 commit

• abff6e0b - Use the correct condition for feature retrieval

Compare with previous version

marked this merge request as ready

changed title from Draft: Add extra triggers for DF-level PHYS(LITE) matching to Add extra triggers for DF-level PHYS(LITE) matching [ATR-24269]

changed the description

This merge request affects 3 packages:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkPhys
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkTrigger
• Trigger/TrigAnalysis/TriggerMatchingTool

Affected files list will not be printed in this case

Adding @zmarshal ,@tamartin ,@dshope as watchers

added Derivation Tau Trigger analysis-review-required master review-pending-level-1 labels

Hi @jburr ,

this looks good technically so fine to approve from the derivations side.

An administrative question: are these lists expected to be relatively stable, or might they change often? Will someone be responsible for keeping them up to date? Since DAOD_PHYS will mostly be made from AODs on tape in run 3, we won't have much scope for re-doing things a couple of weeks later if it turns out one more trigger is needed... the answer might be "it will have to wait for 3 months". So it will be good if these lists are somewhat stable.

Cheers,

James.

resolved all threads

CI Result SUCCESS (hash abff6e0b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40310]

Thanks @jburr

Let me cc in @jmontejo for interest too. If we extend the TriggerAPI for R3 we may e.g. want to consider adding non-primary categories to the API too.

Hi,

just to add that we already have such option built-in, and we used in Run 2 to separate the primaries expected up to 1.7e34 and the primaries up to 2e34. If it affects Run 3 triggers we can use the tags in TM to filter, and the output will evolve with the menu. If it only affects Run 2 triggers we can use TriggerAPI to maintain the lists

Javier

resolved all threads

added review-approved label and removed review-pending-level-1 label

added analysis-review-approved label and removed analysis-review-required label

merged

mentioned in commit 9b958937

added sweep:ignore label

mentioned in merge request !49641 (merged)