CP algs: move more algorithms to use SysReadHandle

Manual sweep of !47108 (merged) to master.

CP algs: move more algorithms to use SysReadHandle. This avoids making unnecessary copies.

FYI @krumnack, the sweep failed as you still need to sweep sequence metadata (tracking of preselection) to master.

added sweep:from 21.2 label

This merge request affects 6 packages:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/FTagAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/MuonAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/TauAnalysisAlgorithms

Affected files list will not be printed in this case

Adding @fsforza ,@krumnack ,@oducu ,@maklein ,@pagessin ,@szambito ,@stavrop ,@jojungge ,@mvanadia ,@tadej ,@yoyamagu ,@gartoni as watchers

added Analysis Egamma JetEtmiss Tau analysis-review-required master review-pending-level-1 labels

mentioned in merge request !46804 (merged)

CI Result FAILURE (hash a2356a3c)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40422]

Overall, the MR looks good but the CI throws

Py:MetaReader        INFO MetaReader is called with the parameter "unique_tag_info_values" set to True. This is a workaround to remove all duplicate values from "/TagInfo" key
Shortened traceback (most recent user call last):
  File "/build2/ci-builds/master/AthAnalysis/build/AthAnalysis/x86_64-centos7-gcc8-opt/jobOptions/AsgAnalysisAlgorithms/OverlapAlgorithmsTest_jobOptions.py", line 35, in <module>
    algSeq = makeOverlapSequence (dataType)
  File "/build2/ci-builds/master/AthAnalysis/build/AthAnalysis/x86_64-centos7-gcc8-opt/python/AsgAnalysisAlgorithms/AsgAnalysisAlgorithmsTest.py", line 49, in makeOverlapSequence
    muonSequence.configure( inputName = 'Muons',
  File "/build2/ci-builds/master/AthAnalysis/build/AthAnalysis/x86_64-centos7-gcc8-opt/python/AnaAlgorithm/AnaAlgSequence.py", line 147, in configure
    setattr( alg, outputPropName, currentInputs[ outputLabel ] )

AttributeError: 'CP__MuonIsolationAlg' object has no attribute 'muonsOut'

which looks related to this MR. Could you please double check, @tadej?

Cheers, Martin (L1)

Hi @tadej, I will add review-user-action-required until the CI issue is solved. Cheers, Ben (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 172 commits

• a2356a3c...049372e6 - 171 commits from branch atlas:master
• a208bc1b - CP algs: move more algorithms to use SysReadHandle

Compare with previous version

This merge request affects 6 packages:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/FTagAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/MuonAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/TauAnalysisAlgorithms

Affected files list will not be printed in this case

Adding @krumnack ,@maklein ,@jojungge ,@mvanadia ,@yoyamagu ,@fsforza ,@oducu ,@szambito ,@pagessin ,@stavrop ,@gabarone ,@tadej ,@gartoni as watchers

added review-pending-level-1 label and removed review-user-action-required label

added 1 commit

• a95ed60b - CP algs: move more algorithms to use SysReadHandle

Compare with previous version

This merge request affects 6 packages:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/EgammaAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/FTagAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/MuonAnalysisAlgorithms
• PhysicsAnalysis/Algorithms/TauAnalysisAlgorithms

Affected files list will not be printed in this case

Adding @krumnack ,@maklein ,@jojungge ,@mvanadia ,@yoyamagu ,@fsforza ,@oducu ,@szambito ,@pagessin ,@stavrop ,@gabarone ,@tadej ,@gartoni as watchers

CI Result FAILURE (hash a208bc1b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40598]

CI Result SUCCESS (hash a95ed60b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40606]

Approving -- L1

added review-approved label and removed review-pending-level-1 label

@krumnack , we need to analysis-approve this one. Thanks.

added analysis-review-approved label and removed analysis-review-required label

added review-user-action-required label