MuonGeoModel - Minor style improvements

Hi,

this MR comprises:

• Fix include order in MuonDetectorFactory to ensure that the MuonReadoutgeometry is loaded first... In this way, we ensure that the GeoPrimitive extensions are loaded properly (addresses ATLINFR-4280)
• Minor clean-up of the MuonDetectorFactory (smart pointers, member initialization when variables are declared)

added full-unit-tests label

There were multiple CI triggers for this MR and commit. The system ignored duplicates. However the GitLab pipelines status may be shown incorrectly.

This merge request affects 1 package:

• MuonSpectrometer/MuonGeoModel

This merge request affects 2 files:

• MuonSpectrometer/MuonGeoModel/MuonGeoModel/MuonDetectorFactory001.h
• MuonSpectrometer/MuonGeoModel/src/MuonDetectorFactory001.cxx

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

added MuonSpectrometer master review-pending-level-1 labels

added 35 commits

• 9e5b4e4d...2b0147d5 - 34 commits from branch atlas:master
• dcc3486d - Merge branch 'master' into 'MuonDetFac_FixIncludes'

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonGeoModel

This merge request affects 2 files:

• MuonSpectrometer/MuonGeoModel/MuonGeoModel/MuonDetectorFactory001.h
• MuonSpectrometer/MuonGeoModel/src/MuonDetectorFactory001.cxx

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

CI Result FAILURE (hash 9e5b4e4d)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40629]

CI Result FAILURE (hash dcc3486d)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40635]

added 2 commits

• acb58b51 - The cond alg takes over the ownership of the manager provided by the factory
• c1b19af6 - Merge branch 'MuonDetFac_FixIncludes' of...

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonGeoModel

This merge request affects 2 files:

• MuonSpectrometer/MuonGeoModel/MuonGeoModel/MuonDetectorFactory001.h
• MuonSpectrometer/MuonGeoModel/src/MuonDetectorFactory001.cxx

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

CI Result FAILURE (hash c1b19af6)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40646]

Jenkins please retry a build

This merge request affects 1 package:

• MuonSpectrometer/MuonGeoModel

This merge request affects 2 files:

• MuonSpectrometer/MuonGeoModel/MuonGeoModel/MuonDetectorFactory001.h
• MuonSpectrometer/MuonGeoModel/src/MuonDetectorFactory001.cxx

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

removed full-unit-tests label

CI Result FAILURE (hash c1b19af6)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40660]

Failure is unrelated.

Jenkins please retry a build

This merge request affects 1 package:

• MuonSpectrometer/MuonGeoModel

This merge request affects 2 files:

• MuonSpectrometer/MuonGeoModel/MuonGeoModel/MuonDetectorFactory001.h
• MuonSpectrometer/MuonGeoModel/src/MuonDetectorFactory001.cxx

Adding @rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers

CI Result SUCCESS (hash c1b19af6)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40675]

removed review-pending-level-1 label