Skip to content
Snippets Groups Projects

TriggerJobOpts+RecExCommon: cleanup trigger BS reco

Merged Frank Winklmeier requested to merge fwinkl/athena:trig_bstoesd into master
All threads resolved!

Delete the obsolete BStoESD_Tier0_HLTConfig_jobOptions.py. There was essentially no difference anymore to the T0TriggerGetter, which it also called, apart from setting the Trigger.readBS flag. Also rename it to TriggerRecoGetter.

Cleanup other job options by either removing the obsolete include or using TriggerRecoGetter.

Relates to ATR-22725.

Edited by Frank Winklmeier

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 82edbdf4 - Rename T0TriggerGetter to TriggerRecoGetter

    Compare with previous version

  • Frank Winklmeier resolved all threads

    resolved all threads

  • Frank Winklmeier changed the description

    changed the description

  • This merge request affects 5 packages:

    • Event/EventOverlay/EventOverlayJobTransforms
    • LArCalorimeter/LArCafJobs
    • Reconstruction/RecExample/RecExCommon
    • Trigger/TrigMonitoring/TrigHLTMonitoring
    • Trigger/TriggerCommon/TriggerJobOpts

    Affected files list will not be printed in this case

    Adding @jchapman ,@goetz ,@ahaas ,@pavol ,@tkharlam ,@tadej ,@ebergeas as watchers

  • added DQ label

  • Frank Winklmeier mentioned in merge request !47416 (merged)

    mentioned in merge request !47416 (merged)

  • :white_check_mark: CI Result SUCCESS (hash 82edbdf4)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40679]

  • Everything looks ok. Moving forward with approval from L1.

  • mentioned in commit a080eb3d

  • Please register or sign in to reply
    Loading