Skip to content
Snippets Groups Projects

TriggerJobOpts: remove TriggerFlags.doHLT

Merged TriggerJobOpts: remove TriggerFlags.doHLT
fwinkl/athena:doHLT into master
All threads resolved!
Merged Frank Winklmeier requested to merge fwinkl/athena:doHLT into master
All threads resolved!

Delete the legacy TriggerFlags.doHLT. There are only very few use-cases where a doHLT flag is even needed and those are already covered by ConfigFlags.Trigger.doHLT (False by default).

This removes the last uses of TriggerFlags from runHLT_standalone (ATR-21276).

Also delete the obsolete writeBS Modifier and its include file.

Needs to wait for !47410 (merged).

Edited by Frank Winklmeier

Merge request reports

Pipeline #3153108 passed

Stage: external

Pipeline passed for 584a4d0f on fwinkl:doHLT

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 3 years ago (Oct 22, 2021 5:27pm UTC)

Merge details

  • Changes merged into master with f8fae691.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Frank Winklmeier resolved all threads

    resolved all threads

  • Frank Winklmeier added 2 commits

    added 2 commits

    • 394d4d04 - TriggerJobOpts: delete writeBS modifier and include file
    • 175734f8 - TriggerJobOpts: remove TriggerFlags.doHLT

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • HLT/Trigger/TrigControl/TrigPSC
    • Trigger/TriggerCommon/TriggerJobOpts

    Affected files list will not be printed in this case

    Adding @bernius ,@wiedenma ,@rbielski ,@fwinkl as watchers

  • Frank Winklmeier changed the description

    changed the description

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 175734f8)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40780]

  • Frank Winklmeier added 89 commits

    added 89 commits

    • 175734f8...9c40f09e - 87 commits from branch atlas:master
    • 441553db - TriggerJobOpts: delete writeBS modifier and include file
    • 584a4d0f - TriggerJobOpts: remove TriggerFlags.doHLT

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • HLT/Trigger/TrigControl/TrigPSC
    • Trigger/TriggerCommon/TriggerJobOpts

    Affected files list will not be printed in this case

    Adding @bernius ,@wiedenma ,@rbielski ,@fwinkl as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 584a4d0f)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40852]

  • Carlo Varni
    Carlo Varni @cvarni ·
    Developer

    Approving -- L1

  • Carlo Varni added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Vakhtang Tsulaia mentioned in commit f8fae691

    mentioned in commit f8fae691

  • Vakhtang Tsulaia merged

    merged

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply