ILayerBuilderCond does not need to return the new Layers it creates as const

ILayerBuilderCond creates new Layers which then pass on,acts as a "factory". These new Layers do not need to be const. Being const unneedlessy leads down the chain to uneeded const_cast (Explicit or implicit) and other syntactic or actual issues.

ping @rlangenb as we discussed this , note that I do this only for the "cond" tools , I assume the older legacy non condition tools used by the svc will be eventually removed.

This merge request affects 4 packages:

• HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_TrackingGeometry
• InnerDetector/InDetDetDescr/InDetTrackingGeometry
• Tracking/TrkDetDescr/TrkDetDescrInterfaces
• Tracking/TrkDetDescr/TrkDetDescrTools

Affected files list will not be printed in this case

Adding @goetz ,@cgrefe ,@amorley ,@dshope ,@cohm ,@calfayan ,@lshan ,@sroe as watchers

added HGTD InnerDetector Tracking master review-pending-level-1 labels

CI Result FAILURE (hash 60dfad5b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40824]

Jenkins please retry a build

This merge request affects 4 packages:

• HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_TrackingGeometry
• InnerDetector/InDetDetDescr/InDetTrackingGeometry
• Tracking/TrkDetDescr/TrkDetDescrInterfaces
• Tracking/TrkDetDescr/TrkDetDescrTools

Affected files list will not be printed in this case

Adding @goetz ,@cgrefe ,@amorley ,@dshope ,@cohm ,@calfayan ,@lshan ,@sroe as watchers

CI Result SUCCESS (hash 60dfad5b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40844]

Changes look fine -- L1

added review-approved label and removed review-pending-level-1 label

mentioned in commit b7e1bfc0

merged

added sweep:ignore label

mentioned in merge request !47538 (merged)

mentioned in merge request !56062 (merged)

mentioned in commit 597acd5f

mentioned in commit 61ba4e69