Avoid usage of eventTypeBitmask for skimming

Hello @wbalunas @schaarsc @sawyer @mswiatlo @camacho @khoo ,

There are some issues with the usage of eventTypeBitmask in release 22 that is used in the event skimming. When I'm trying to run JETM1, I always get an error message that this variable is a vector and I'm trying to read it as a boolean. The variable is not a vector actually and I don't really see differences w.r.t r21. I've checked at some point on PATHelp but people were also a bit clueless there. I went ahead and modified JETM1 to avoid this problem. Basically what I do now is check whether or not we run over data / MC and only schedule the skimming tools for data which is I think the behaviour that we had in r21.2 unless I misunderstood the code. If someone could take a quick look to see if they agree with my logic that would be really helpful. I ran a test in both data and MC and they ran fine and I have events in the output.

Thanks and cheers, Chris

Seems fine as far as I can tell. I was under the impression that this was the better way to check whether we're running over data or MC anyway - it's more readable and doesn't require accessing the file. No idea what's changed in the event type bitmask, but it probably doesn't matter for us anyway. My reading of the old code (though I'm not an expert on how the skimming is set up) is "keep the event if it (is data) or (passes the MET trigger) or (passes any trigger in the jet list)", and what you have here appears to do the same thing.

Thanks so much for taking a look @wbalunas. I think your expression should be the following though?!

(is MC) or (passes the MET trigger) or (passes any trigger in the jet list)

Thanks!

marked this merge request as ready

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss

This merge request affects 1 file:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss/share/JETM1.py

Adding @jmellent ,@jveatch ,@nelsonc ,@ispokhar as watchers

added Derivation JetEtmiss master review-pending-level-1 labels

CI Result SUCCESS (hash 5ab458d8)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40998]

Looks good. Approved

Sergei L1

added review-approved label and removed review-pending-level-1 label

mentioned in commit 5beee9ae

merged

added sweep:ignore label