TriggerJobOpts: cleanup TriggerConfigGetter and flags

This is rather big cleanup of TriggerConfigGetter:

• Replace TriggerFlags.dataTakingConditions by ConfigFlags.Trigger.availableRecoMetadata: this flag is used to indicate the trigger systems that are enabled during reconstruction. It is set based on the L1/HLT keys in COOL or the metadata in the input file.
• Remove obsolete metadataItems setting as discussed with @tamartin (the key names are not relevant anymore, and we are setting this elsewhere already).
• Deprecate TriggerFlags.configForStartup: this flag was used to indicate whether trigger keys can be found in COOL. But this is essentially the same check as availableRecoMetadata performs already. The flag itself is still there but will print a WARNING if set. Once this is merged, should update reprocessing shifter instructions to not add this to the AMI tag anymore (discussed with @mark).
• Fix the broken getKeysFromCool method in TrigConfigSvc.

I did not re-implement the setting of the DQMonFlags based on the available systems. If this is really needed still for the legacy monitoring it should be done in the relevant DQ job options. There are also a few TODO items left in the code that will be cleaned up separately. And once the dust has settled, we can think about migrating this to CA.

Relates to ATR-23102.

cc @rbielski

added full-unit-tests label

Jenkins please retry a build

This merge request affects 3 packages:

• Reconstruction/RecExample/RecExCond
• Trigger/TrigConfiguration/TrigConfigSvc
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @goetz ,@paulama ,@asonay ,@orlando ,@cmorenom ,@mark as watchers

added JetEtmiss Reconstruction Trigger master labels

CI Result FAILURE (hash b2eafcfe)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40900]

Failures are unrelated but still giving some time for experts to give feedback on these changes before un-WIPing.

removed full-unit-tests label

added 1 commit

• 8f8653f9 - TriggerJobOpts: cleanup TriggerConfigGetter and flags

Compare with previous version

added 74 commits

• 8f8653f9...158dfd8b - 72 commits from branch atlas:master
• a62bb8f3 - TrigConfigSvc: fix broken getKeysFromCool method
• 6966dd8a - TriggerJobOpts: cleanup TriggerConfigGetter and flags

Compare with previous version

changed the description

resolved all threads

marked this merge request as ready

added 1 commit

• c5f0ac52 - TriggerJobOpts: cleanup TriggerConfigGetter and flags

Compare with previous version

This merge request affects 3 packages:

• Reconstruction/RecExample/RecExCond
• Trigger/TrigConfiguration/TrigConfigSvc
• Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @goetz ,@paulama ,@asonay ,@orlando ,@cmorenom ,@mark as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash c5f0ac52)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40985]