Add Parameters from ConfiguredNewTrackingTrigCuts to ConfigSettings

This MR aims to resolve the low efficiency described in ATR-24341 whilst transitioning LRT to the new PT config system.

The items have been suffixed with Trig to avoid a conflict with flags from InDetConfig/TrackingCutFlags such as maxZImpact, this conflict creates a conflict in TrigTrackingCutFlags, which results in a duplicate flag exception.

Related JIRA: ATR-24341

Hi @bkerridg, I think adding the suffix Trig to the new trigger precision flags in ConfigSettings is fine. But @tbold might suggest a better way to avoid the name clash inside TrigTrackingCutFlags.py. One thing - I think we need to add add additional FlagsCategory for the FSLRT electroLRT etc. here : https://gitlab.cern.ch/bkerridg/athena/-/blame/master-ATR24341-benjamin/Trigger/TrigTools/TrigInDetConfig/python/TrigTrackingCutFlags.py#L64 cheers John

added 1 commit

• 94618ac8 - change postfix from Trig to PT

Compare with previous version

added 2 commits

• d3db2405 - extend pt lrt config changes to other signatures
• 0b55fcf6 - typo fixed

Compare with previous version

marked this merge request as ready

marked this merge request as draft

marked this merge request as ready

resolved all threads

There were multiple CI triggers for this MR and commit. The system ignored duplicates. However the GitLab pipelines status may be shown incorrectly.

This merge request affects 1 package:

• Trigger/TrigTools/TrigInDetConfig

This merge request affects 3 files:

• Trigger/TrigTools/TrigInDetConfig/python/ConfigSettings.py
• Trigger/TrigTools/TrigInDetConfig/python/ConfigSettingsBase.py
• Trigger/TrigTools/TrigInDetConfig/python/InDetPT.py

Adding @sutt ,@nagano ,@mvozak as watchers

added Trigger TriggerID master review-pending-level-1 labels

jenkins try a rebuild

Jenkins please retry a build

There were multiple CI triggers for this MR and commit. The system ignored duplicates. However the GitLab pipelines status may be shown incorrectly.

CI Result FAILURE (hash 0b55fcf6)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 41121]

Jenkins please retry a build

This merge request affects 1 package:

• Trigger/TrigTools/TrigInDetConfig

This merge request affects 3 files:

• Trigger/TrigTools/TrigInDetConfig/python/ConfigSettings.py
• Trigger/TrigTools/TrigInDetConfig/python/ConfigSettingsBase.py
• Trigger/TrigTools/TrigInDetConfig/python/InDetPT.py

Adding @sutt ,@nagano ,@mvozak as watchers

CI Result SUCCESS (hash 0b55fcf6)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 41143]

resolved all threads

CI is all green now, changes look fine from L1 side. Approving.

Cheers, Volker (L1)