Remove un-needed const returns from builders/creators. Rm unneeded const methods TrackingGeometry.h. Preparation to remove const_cast

Builders/creators do not need to return what they just created as const. Rm unneeded const methods TrackingGeometry.h.

In preparation of trying to redice "unneeded" const_cast

WARNING: big files (>100K) are found in the changeset

144K in file MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/src/MuonTrackingGeometryBuilderCond.cxx

140K in file MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/src/MuonTrackingGeometryBuilder.cxx

This merge request affects 8 packages:

• Calorimeter/CaloTrackingGeometry
• HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_TrackingGeometry
• InnerDetector/InDetDetDescr/InDetTrackingGeometry
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry
• TileCalorimeter/TileTrackingGeometry
• Tracking/TrkDetDescr/TrkDetDescrInterfaces
• Tracking/TrkDetDescr/TrkDetDescrTools
• Tracking/TrkDetDescr/TrkGeometry

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@dshope ,@wleight ,@cohm ,@stavrop ,@pavol ,@sroe ,@rosati ,@solodkov ,@jojungge ,@harkusha ,@egodden ,@lshan as watchers

added Calorimeter HGTD InnerDetector JetEtmiss MuonSpectrometer Tile Tracking master review-pending-level-1 labels

CI Result FAILURE (hash 7b3e9600)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40987]

added 1 commit

• 613cd37c - Also Lar Geoemtry

Compare with previous version

WARNING: big files (>100K) are found in the changeset

144K in file MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/src/MuonTrackingGeometryBuilderCond.cxx

140K in file MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry/src/MuonTrackingGeometryBuilder.cxx

This merge request affects 9 packages:

• Calorimeter/CaloTrackingGeometry
• HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_TrackingGeometry
• InnerDetector/InDetDetDescr/InDetTrackingGeometry
• LArCalorimeter/LArTrackingGeometry
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry
• TileCalorimeter/TileTrackingGeometry
• Tracking/TrkDetDescr/TrkDetDescrInterfaces
• Tracking/TrkDetDescr/TrkDetDescrTools
• Tracking/TrkDetDescr/TrkGeometry

Affected files list will not be printed in this case

Adding @goetz ,@amorley ,@dshope ,@wleight ,@cohm ,@stavrop ,@pavol ,@sroe ,@rosati ,@solodkov ,@jojungge ,@harkusha ,@egodden ,@lshan as watchers

added LAr label

CI Result SUCCESS (hash 613cd37c)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 40993]

Looks good. Approved

Sergei L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit d03532f4

added sweep:ignore label