Skip to content
Snippets Groups Projects

L1Topo - trigger counts fix

Merged Paula Martinez Suarez requested to merge paulama/athena:L1Topo-ATR-24202-fix into master
All threads resolved!

Fix units of dR, dPhi and dEta for legacy and phase-I algorithms + other minor issues.

ATR-24202

Tagging @orlando @iriu @asonay @cmorenom.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 6 commits

    Compare with previous version

  • Daniele Zanzi resolved all threads

    resolved all threads

  • added 13 commits

    Compare with previous version

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 116K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

    :pencil: 188K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

  • This merge request affects 5 packages:

    • Trigger/TrigT1/L1Topo/L1TopoAlgorithms
    • Trigger/TrigT1/L1Topo/L1TopoInterfaces
    • Trigger/TrigT1/L1Topo/L1TopoSimulationUtils
    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigP1Test

    Affected files list will not be printed in this case

    Adding @jchapman ,@salderwe ,@iriu ,@vmartin ,@okumura ,@kwhalen ,@orlando ,@cmorenom ,@paulama ,@asonay ,@afaulkne as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash 173b94c6)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 41028]

  • Hello, possibly an interference from !47561 (merged) merged earlier today...

  • Adam Edward Barton resolved all threads

    resolved all threads

  • mentioned in commit 92c746cd

  • Please register or sign in to reply
    Loading