GeoModelXml+PixelGeoModelXml+StripGeoModelXml: Fix cppcheck warnings.

Fix cppcheck warnings. (Mostly change to pass strings by const reference.)

This merge request affects 3 packages:

• DetectorDescription/GeoModelXml
• InnerDetector/InDetDetDescr/PixelGeoModelXml
• InnerDetector/InDetDetDescr/StripGeoModelXml

Affected files list will not be printed in this case

Adding @goetz ,@stavrop ,@battagl ,@sroe ,@jojungge ,@stsuno ,@lshan ,@rbianchi as watchers

added Geometry ITk InnerDetector master review-pending-level-1 labels

CI Result FAILURE (hash 47d6cfa3)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 41009]

Error related to this MR. change the label

error: 'virtual void InDetDD::PLRGmxInterface::addSensorType(std::__cxx11::string, std::__cxx11::string, std::map<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char> >)' marked 'override', but does not override
   virtual void addSensorType(std::string clas,

Sergei L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• c7309d2e - Also need to adjust interface in PLRGeoModelXml

Compare with previous version

This merge request affects 4 packages:

• DetectorDescription/GeoModelXml
• InnerDetector/InDetDetDescr/PLRGeoModelXml
• InnerDetector/InDetDetDescr/PixelGeoModelXml
• InnerDetector/InDetDetDescr/StripGeoModelXml

Affected files list will not be printed in this case

Adding @goetz ,@stavrop ,@battagl ,@sroe ,@jojungge ,@stsuno ,@lshan ,@rbianchi as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash c7309d2e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 41097]

Changes look fine, CI failure should be unrelated. Approving -- L1

added review-approved label and removed review-pending-level-1 label

mentioned in commit 6e178dbb

merged

added sweep:ignore label

mentioned in merge request GeoModelDev/GeoModel!104 (merged)

mentioned in merge request !48216 (merged)

mentioned in commit bc13cfe6