The source project of this merge request has been removed.
Pulse simulator updates for Tile Phase-II
All threads resolved!
All threads resolved!
Updates in the Athena Pulse Simulator for Tile Phase-II (bit range, gains, number of samples, pedestals, pulse shapes, noise values and pile-up)
Merge request reports
Activity
Filter activity
added Digitization JetEtmiss Tile master review-pending-level-1 labels
Hi @agomezde,
Please update the ComponentAccumulator based configuration too, as the plan is to deprecate the old-style job options early next year. (ComponentAccumulator is already the default for P2 Upgrade jobs.)
Cheers,
John
-
Hi @agomezde, I have a few minor comments.
Also for the future it might be beneficial if you improve the memory management in the code (i.e. use smart pointers) and move to the ComponentAccumulator-based configuration.
added review-user-action-required label and removed review-pending-level-1 label
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals 
cmake make 
required tests 
optional tests Full details available on this CI monitor view
added 280 commits
-
aaa94c28...a44f1264 - 277 commits from branch
atlas:master - ddc40895 - Variable name changes and comment removal
- cd443eb2 - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into pulse-simulator-tests
- 17b02e24 - Merge branch 'pulse-simulator-tests' of...
Toggle commit list-
aaa94c28...a44f1264 - 277 commits from branch
added review-pending-level-1 label and removed review-user-action-required label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
Hi @agomezde, this MR introduces the following warnings during compilation. Can you please address them?
# CMake ---> /cvmfs/sft.cern.ch/lcg/releases/gcc/8.3.0-cebb0/x86_64-centos7/bin/g++ -DATLAS_GAUDI_V21 -DATLAS_PACKAGE_NAME="TileRec" -DBOOST_ALL_NO_LIB -DBOOST_FILESYSTEM_DYN_LINK -DBOOST_REGEX_DYN_LINK -DBOOST_SYSTEM_DYN_LINK -DBOOST_THREAD_DYN_LINK -DCLHEP_ABS_DEFINED -DCLHEP_MAX_MIN_DEFINED -DCLHEP_SQR_DEFINED -DFMT_LOCALE -DFMT_SHARED -DGAUDI_V20_COMPAT -DHAVE_GAUDI_PLUGINSVC -DJSON_USE_IMPLICIT_CONVERSIONS=1 -DTileRec_EXPORTS -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthenaBaseComps -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthenaKernel -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/CxxUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/DataModelRoot -I/cvmfs/sft.cern.ch/lcg/releases/Boost/1.75.0-e9c3f/x86_64-centos7-gcc8-opt/include -I/cvmfs/sft.cern.ch/lcg/releases/LCG_100_ATLAS_7/fmt/7.1.3/x86_64-centos7-gcc8-opt/include -I/cvmfs/sft.cern.ch/lcg/releases/LCG_100_ATLAS_7/jsonmcpp/3.9.1/x86_64-centos7-gcc8-opt/include -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODEventInfo -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainers -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthContainersInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthLinks -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/SGTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthAllocators -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODCore -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/RootUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/StoreGate -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/PersistentDataModel -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/EventContainers -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/Identifier -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileConditions -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloConditions -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloIdentifier -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloGeoHelpers -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/AtlasDetDescr -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/IdDict -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloCondBlobObjs -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/AthenaPOOL/AthenaPoolUtilities -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/APR/CollectionBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/APR/FileCatalog -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/APR/POOLCore -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileCalib/TileCalibBlobObjs -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileIdentifier -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloDetDescr -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/GeoModel/GeoModelInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DetectorDescription/GeoPrimitives -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/EventPrimitives -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LArCalorimeter/LArGeoModel/LArReadoutGeometry -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LArCalorimeter/LArGeoModel/LArHV -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/Navigation -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/EventKernel -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/VxVertex -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkEventPrimitives -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkNeutralParameters -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkDetDescr/TrkSurfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkParametersBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkDetDescr/TrkDetDescrUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkDetDescr/TrkDetElementBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkTrackLink -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkEvent/TrkParameters -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/FourMom -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/NavFourMom -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LArCalorimeter/LArRawConditions -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LArCalorimeter/LArIdentifier -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LArCalorimeter/LArElecCalib -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LArCalorimeter/LArCabling -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileSimEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Simulation/HitManagement -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/EventInfo -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileDetDescr -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/RDBAccessSvc -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/DBLock -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileL2Algs -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileSvc/TileByteStream -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/ByteStreamData -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/ByteStreamCnvSvcBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/ByteStreamCnvSvc -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRecUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloInterface -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODCaloEvent -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODBase -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloUtils -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LumiBlock/LumiBlockComps -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODLuminosity -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LumiBlock/LumiCalc -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/DataQuality/GoodRunsLists -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgMessaging -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/PhysicsAnalysis/Interfaces/AsgAnalysisInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/PhysicsAnalysis/AnalysisCommon/PATInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/PhysicsAnalysis/D3PDTools/AnaAlgorithm -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/EventBookkeeperTools -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/IOVDbDataModel -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODMetaData -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODTruth -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Control/AthToolSupport/AsgDataHandles -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Event/xAOD/xAODCutFlow -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/PhysicsAnalysis/DerivationFramework/DerivationFrameworkInterfaces -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/LumiBlock/LumiBlockData -I/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Database/CoolLumiUtilities -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_100_ATLAS_7/ROOT/v6.24.00/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_100_ATLAS_7/Boost/1.75.0/x86_64-centos7-gcc8-opt/include -isystem /build2/ci-builds/master/Athena/install/AthenaExternals/22.0.47/InstallArea/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_100_ATLAS_7/tbb/2020_U2/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_100_ATLAS_7/cppgsl/3.1.0/x86_64-centos7-gcc8-opt/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_100_ATLAS_7/CORAL/3_3_8/x86_64-centos7-gcc8-opt/include -isystem /build2/ci-builds/master/Athena/install/AthenaExternals/22.0.47/InstallArea/x86_64-centos7-gcc8-opt/lib/CLHEP-2.4.1.3/../../include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_100_ATLAS_7/eigen/3.3.7/x86_64-centos7-gcc8-opt/include/eigen3 -isystem /cvmfs/atlas.cern.ch/repo/sw/tdaq/tdaq-common/tdaq-common-04-03-00/installed/include -isystem /cvmfs/sft.cern.ch/lcg/releases/LCG_100_ATLAS_7/COOL/3_3_8/x86_64-centos7-gcc8-opt/include -fplugin=/build2/ci-builds/master/Athena/install/AthenaExternals/22.0.47/InstallArea/x86_64-centos7-gcc8-opt/lib/libchecker_gccplugins.so -DNDEBUG -O2 -Wall -Wno-long-long -Wno-deprecated -Wno-unused-local-typedefs -Wwrite-strings -Wpointer-arith -Woverloaded-virtual -Wextra -Werror=return-type -pedantic -fPIC -pthread -std=c++17 -MD -MT TileCalorimeter/TileRec/CMakeFiles/TileRec.dir/src/components/TileRec_entries.cxx.o -MF CMakeFiles/TileRec.dir/src/components/TileRec_entries.cxx.o.d -o CMakeFiles/TileRec.dir/src/components/TileRec_entries.cxx.o -c /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/components/TileRec_entries.cxx /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx: In member function 'StatusCode TileAANtuple::storeMFRawChannels(const EventContext&, const SG::ReadHandleKey<TileRawChannelContainer>&, float*, float*, float (*)[64][48], float (*)[64][48], bool)': /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:856:59: warning: ISO C++ forbids variable length array 'ene_temp' [-Wvla] short (*ene_temp)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) ene; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:856:111: warning: ISO C++ forbids variable length array [-Wvla] short (*ene_temp)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) ene; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:857:60: warning: ISO C++ forbids variable length array 'time_temp' [-Wvla] short (*time_temp)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) time; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:857:112: warning: ISO C++ forbids variable length array [-Wvla] short (*time_temp)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) time; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx: In member function 'StatusCode TileAANtuple::storeDigits(const EventContext&, const SG::ReadHandleKey<TileDigitsContainer>&, short int*, short int (*)[64][48], bool)': /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:1074:57: warning: ISO C++ forbids variable length array 'sample' [-Wvla] short (*sample)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) a_sample; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:1074:109: warning: ISO C++ forbids variable length array [-Wvla] short (*sample)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) a_sample; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx: In member function 'StatusCode TileAANtuple::storeTMDBDigits(const EventContext&)': /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:1303:74: warning: ISO C++ forbids variable length array 'sampleTMDB' [-Wvla] unsigned char (*sampleTMDB)[N_ROS][N_MODULES][N_TMDBCHANS][m_nSamples] = (unsigned char(*)[N_ROS][N_MODULES][N_TMDBCHANS][m_nSamples]) m_arrays->m_sampleTMDB; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:1303:137: warning: ISO C++ forbids variable length array [-Wvla] unsigned char (*sampleTMDB)[N_ROS][N_MODULES][N_TMDBCHANS][m_nSamples] = (unsigned char(*)[N_ROS][N_MODULES][N_TMDBCHANS][m_nSamples]) m_arrays->m_sampleTMDB; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx: In member function 'void TileAANtuple::DIGI_addBranch()': /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:1862:57: warning: ISO C++ forbids variable length array 'sample' [-Wvla] short (*sample)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) m_arrays->m_sample; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:1862:109: warning: ISO C++ forbids variable length array [-Wvla] short (*sample)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) m_arrays->m_sample; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:1863:60: warning: ISO C++ forbids variable length array 'sampleFlt' [-Wvla] short (*sampleFlt)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) m_arrays->m_sampleFlt; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:1863:112: warning: ISO C++ forbids variable length array [-Wvla] short (*sampleFlt)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) m_arrays->m_sampleFlt; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:1864:54: warning: ISO C++ forbids variable length array 'eMF' [-Wvla] short (*eMF)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) m_arrays->m_eMF; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:1864:106: warning: ISO C++ forbids variable length array [-Wvla] short (*eMF)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) m_arrays->m_eMF; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:1865:54: warning: ISO C++ forbids variable length array 'tMF' [-Wvla] short (*tMF)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) m_arrays->m_tMF; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:1865:106: warning: ISO C++ forbids variable length array [-Wvla] short (*tMF)[N_ROS2][N_MODULES][N_CHANS][m_nSamples] = (short(*)[N_ROS2][N_MODULES][N_CHANS][m_nSamples]) m_arrays->m_tMF; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx: In member function 'void TileAANtuple::TMDB_addBranch()': /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:2171:64: warning: ISO C++ forbids variable length array 'sampleTMDB' [-Wvla] short (*sampleTMDB)[N_ROS][N_MODULES][N_TMDBCHANS][m_nSamples] = (short(*)[N_ROS][N_MODULES][N_TMDBCHANS][m_nSamples]) m_arrays->m_sampleTMDB; ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/TileCalorimeter/TileRec/src/TileAANtuple.cxx:2171:119: warning: ISO C++ forbids variable length array [-Wvla] short (*sampleTMDB)[N_ROS][N_MODULES][N_TMDBCHANS][m_nSamples] = (short(*)[N_ROS][N_MODULES][N_TMDBCHANS][m_nSamples]) m_arrays->m_sampleTMDB;The CI errors may disappear when running again the CI.
-- L1
added review-user-action-required label and removed review-pending-level-1 label
added 207 commits
-
17b02e24...398ceed5 - 205 commits from branch
atlas:master - b15ac321 - Change samples structure in ntupler
- 3dfb8900 - Merge branch 'master' of https://gitlab.cern.ch:8443/atlas/athena into pulse-simulator-tests
-
17b02e24...398ceed5 - 205 commits from branch
added review-pending-level-1 label and removed review-user-action-required label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
added review-user-action-required label
removed review-pending-level-1 label
added review-pending-level-1 label and removed review-user-action-required label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view
added review-approved label and removed review-pending-level-1 label
mentioned in commit 1e042d1f
added sweep:ignore label
Please register or sign in to reply