Remove variables availability check in MuonSelectorToolsTester

This MR removes some lines from MuonSelectorToolsTester. These lines check the availability of certain variables used in the muon selection, and prints a message if they are missing. They can cause a crash in rare circumstances, if the primary track pointer of the muon is a null pointer. Rather than implementing a null pointer test, I prefer to remove the lines because the list of variables checked is not exhaustive of all variables used in the muon selection. There is no point in fixing this and spending effort on keeping this part up to date, because the MuonSelectionTool itself prints a warning for any missing variables, which will show up in any case when running the tester.

added 21.2 + 1 deleted label

This merge request affects 1 package:

• PhysicsAnalysis/MuonID/MuonSelectorTools

This merge request affects 1 file:

• PhysicsAnalysis/MuonID/MuonSelectorTools/util/MuonSelectorToolsTester.cxx

Adding @stavrop ,@jojungge as watchers

added Analysis analysis-review-required review-pending-level-1 labels

Two CI jobs are triggered by 21.2 MR events: for AthDerivation with gcc62 compiler and with gcc8 for AnalysisBase and AthAnalysis projects.

• Developers and shifters need to wait for both results, sometimes for additional hour or two.

CI Result SUCCESS (hash bcf65631)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 41156]

Out of curiosity.How can the primaryTrackParticle become a nullptr?

I am not sure exactly how it happens, from the point of view of the reconstruction chain. If you are interested, you can find the example that triggered this MR in the file

mc16_13TeV.424101.Pythia8B_A14_CTEQ6L1_Jpsimu2mu2.deriv.DAOD_MUON1.e3982_s3126_r9364_p4145/DAOD_MUON1.21179895._000002.pool.root.1

In event number 5122656, run number 284500:

MuonSelectorToolsTester INFO ===== Muon number: 3

MuonSelectorToolsTester INFO Muon truthType: 0 (Other)

MuonSelectorToolsTester INFO Muon pT [GeV]: 2.10225

MuonSelectorToolsTester INFO Muon eta, phi: 1.66234, -0.859854

MuonSelectorToolsTester INFO Muon muonType: 2 (segment-tagged)

MuonSelectorToolsTester INFO Muon primary author: 4 (MuTagIMO)

You can see that this is a very-low-pT segment-tagged muon close to the threshold of 2 GeV used for segment-tagged reconstruction. I guess there was an ID track at some point and it got removed for some reason?

Actually, that must not happen at all. We need to check the inputs for the DAOD and ensure that the primary track is still present there. Then we need to take a look a the ID track slimming in the derivations.

He @mbugge,

we found a naughty muon in the reprocessing, where the primary track is assisnated on its way to the file. I do not know why this happens, yet. But we should ensure that those muons are rejected by MST. Is such a mechanism already in place?

Hi, @jojungge

For any muon type with an ID track, missing the primary track will lead to rejection: https://gitlab.cern.ch/atlas/athena/blob/master/PhysicsAnalysis/MuonID/MuonSelectorTools/Root/MuonSelectionTool.cxx#L599

For a stand-alone muon missing the ME track, I am not sure. The selection will fail if the necessary hits summary information cannot be extracted from the muon object: https://gitlab.cern.ch/atlas/athena/blob/master/PhysicsAnalysis/MuonID/MuonSelectorTools/Root/MuonSelectionTool.cxx#L488

If you know the example file with the problem, I could also try to run the selection tool to make sure.

CI Result SUCCESS (hash bcf65631)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-GCC62-CC7 1164]

merged

mentioned in commit 6bc49f89

added sweep:done label

picked the changes into the branch cherry-pick-6bc49f8978f-master with commit d32ac41c

mentioned in commit d32ac41c

Sweep summary
successful:

• master

(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/1825/console for details)

mentioned in merge request !47689 (merged)

resolved all threads

mentioned in commit 3ccea1fe

added analysis-review-approved label