Skip to content
Snippets Groups Projects

Create ATLFAST3F_G4MS configuration for ISF

Merged John Derek Chapman requested to merge jchapman/athena:ATLFAST3F_G4MS_master into master
All threads resolved!

This configuration combines old Fatras in the ID, with FastCaloSimV2/FastCaloGAN in the Calo and Geant4 in the MuonSpectrometer.

The configuration is implemented in both the old ConfiguredFactory style and the new ComponentAccumulator style. Currently the output of jobs using the CA-based configuration differs from those using the old style configuration, but that should hopefully be fixed by other MRs soon.

Edited by John Derek Chapman

Merge request reports

Pipeline #3468546 passed

Pipeline passed for 8f78f95e on jchapman:ATLFAST3F_G4MS_master

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 3 years ago (Jan 21, 2022 6:35pm UTC)

Merge details

  • Changes merged into master with 1817cee3.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Carlo Varni
  • John Derek Chapman resolved all threads

    resolved all threads

  • Hi @cvarni,

    Thanks for the careful review. Hopefully my replies to your comments are OK?

    Cheers,

    John

  • @jchapman I assume you intended to remove the review-user-action-required label?

    If yes, and you don't intend to add any changes, then this can be approved.

    Cheers, Steffen (L1)

    Edited by Steffen Korn
  • Thanks yes.

    Cheers,

    John

  • All right,

    approving.

    Cheers, Steffen (L1)

  • mentioned in commit 1817cee3

  • Please register or sign in to reply
    Loading