Create ATLFAST3F_G4MS configuration for ISF
This configuration combines old Fatras in the ID, with FastCaloSimV2/FastCaloGAN in the Calo and Geant4 in the MuonSpectrometer.
The configuration is implemented in both the old ConfiguredFactory
style and the new ComponentAccumulator
style. Currently the output of jobs using the CA-based configuration differs from those using the old style configuration, but that should hopefully be fixed by other MRs soon.
Merge request reports
Activity
added 678 commits
-
99a46f7d...e7c4a6d3 - 677 commits from branch
atlas:master
- fcaac695 - Initial version of ATLFAST3F_G4MS old and new config doesn't quite work yet in CA
-
99a46f7d...e7c4a6d3 - 677 commits from branch
added 1173 commits
-
fcaac695...752a3f5d - 1172 commits from branch
atlas:master
- 347abee2 - Initial version of ATLFAST3F_G4MS old and new config doesn't quite work yet in CA
-
fcaac695...752a3f5d - 1172 commits from branch
added 101 commits
-
347abee2...dfa97fb9 - 100 commits from branch
atlas:master
- 6753f159 - Initial version of ATLFAST3F_G4MS old and new config doesn't quite work yet in CA
-
347abee2...dfa97fb9 - 100 commits from branch
added NewConfig label
added 4 commits
- 286e1b78 - Clean-up CA-based configuration of ISF ParticlePositionFilter
- 8c78f8a1 - Clean-up random number service configuration for Fatras in CA
- a05bdbcc - Alignment CondAlgs not required when TrackingGeometrySvc is used in Simulation
- 981a293d - Further clean-up of TrackingGeometrySvc configuration for ISF_FatrasMaterialUpdator
Toggle commit listadded 112 commits
-
e4b8f14f...4bf51992 - 107 commits from branch
atlas:master
- 5a7e2d6e - Initial version of ATLFAST3F_G4MS old and new config doesn't quite work yet in CA
- 7788b11d - Alignment CondAlgs not required when TrackingGeometrySvc is used in Simulation
- c5fd3d10 - Further clean-up of TrackingGeometrySvc configuration for ISF_FatrasMaterialUpdator
- c866c84b - Fix test_RUN3_FullG4_QS_ZPrime.sh
- b5c4ee5e - local hacks for debugging
Toggle commit list-
e4b8f14f...4bf51992 - 107 commits from branch
added 82 commits
-
b5c4ee5e...6d8a1aab - 78 commits from branch
atlas:master
- 17d7abc1 - Alignment CondAlgs not required when TrackingGeometrySvc is used in Simulation
- 55af7c2c - Further clean-up of TrackingGeometrySvc configuration for ISF_FatrasMaterialUpdator
- c42a8f71 - Initial version of ATLFAST3F_G4MS old and new config doesn't quite work yet in CA
- 0e6bc85b - local hacks for debugging
Toggle commit list-
b5c4ee5e...6d8a1aab - 78 commits from branch
added 148 commits
-
0e6bc85b...e761ad88 - 144 commits from branch
atlas:master
- 9f69e4fa - Initial version of ATLFAST3F_G4MS old and new config doesn't quite work yet in CA
- 0424dca1 - local hacks for debugging
- 18c3d004 - Hack to prevent unused Tile condAlgs being configured in simulation
- 1a9c5c13 - Hacks to prevent unused LAr CondAlgs from being configured during simulation jobs
Toggle commit list-
0e6bc85b...e761ad88 - 144 commits from branch
added 62 commits
-
1a9c5c13...842f97c2 - 61 commits from branch
atlas:master
- f924ed4d - Initial version of ATLFAST3F_G4MS configuration
-
1a9c5c13...842f97c2 - 61 commits from branch
This merge request affects 8 packages:
- Simulation/G4Atlas/G4AtlasApps
- Simulation/G4Atlas/G4AtlasServices
- Simulation/ISF/ISF_Config
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices
- Simulation/SimuJobTransforms
- Simulation/Tests/ISF_Validation
- Simulation/Tests/ISF_ValidationMT
- Tracking/TrkConfig
Affected files list will not be printed in this case
Adding @jchapman ,@amorley ,@pjacka ,@mfauccig ,@ahasib ,@schaarsc ,@tadej ,@xiaozhon as watchers
added Simulation Tracking master review-pending-level-1 labels
added 1 commit
- 8f78f95e - Initial version of ATLFAST3F_G4MS configuration
This merge request affects 8 packages:
- Simulation/G4Atlas/G4AtlasApps
- Simulation/G4Atlas/G4AtlasServices
- Simulation/ISF/ISF_Config
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimServices
- Simulation/SimuJobTransforms
- Simulation/Tests/ISF_Validation
- Simulation/Tests/ISF_ValidationMT
- Tracking/TrkConfig
Affected files list will not be printed in this case
Adding @jchapman ,@amorley ,@pjacka ,@mfauccig ,@ahasib ,@schaarsc ,@tadej ,@xiaozhon as watchers
CI Result FAILURE (hash f924ed4d)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45347] CI Result SUCCESS (hash 8f78f95e)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45353]- Resolved by John Derek Chapman
- Resolved by John Derek Chapman
added review-user-action-required label and removed review-pending-level-1 label
removed review-user-action-required label
added review-pending-level-1 review-user-action-required labels
Hi @cvarni,
Thanks for the careful review. Hopefully my replies to your comments are OK?
Cheers,
John
@jchapman I assume you intended to remove the
review-user-action-required
label?If yes, and you don't intend to add any changes, then this can be approved.
Cheers, Steffen (L1)
Edited by Steffen Kornremoved review-user-action-required label
removed review-pending-level-1 label
added review-approved label
mentioned in commit 1817cee3
added sweep:ignore label