Changes to read trigger menu JSON from metadata

marked this merge request as draft

This merge request affects 6 packages:

Control/AthenaConfiguration
Tools/PyUtils
Trigger/TrigConfiguration/TrigConfIO
Trigger/TrigConfiguration/TrigConfigSvc
Trigger/TrigMonitoring/TrigMinBiasMonitoring
Trigger/TriggerCommon/TriggerJobOpts

Affected files list will not be printed in this case

Adding @paulama ,@asonay ,@orlando ,@ssnyder ,@cmorenom ,@mark as watchers

added Core DQ JetEtmiss Tools Trigger TriggerMinBias master review-pending-level-1 labels

added 1 commit

63ebf0a2 - Added L1 menu reading

Compare with previous version

Prescales were not present in the file that I rested over (reprocessing file from about a month ago).

That's not good! We flag the BG JSON as being optional as we don't yet have a CondAlg for it. But for the other four JSON collections {HLT, L1, HLTPS, L1PS}, these should be present in all POOL files produced in master.

using older AODs that are meant for testing CA JOs fails. Missing JSON menu data. What should we do about those?

This is a good point, the ['TriggerMenu']['HLTChains'] method will also work for the Run 2 metadata payload.

And we cannot entirely get rid of this in master due to the Run 2 MC :(

Perhaps for the three Derivation use-cases we could try and use getHLTMenuAccess and fall-back on ['TriggerMenu']['HLTChains'] - but only as populated by this function https://acode-browser1.usatlas.bnl.gov/lxr/source/athena/Tools/PyUtils/python/MetaReader.py#0683, NOT populated from JSON.

Then in the future we would be able to remove the fall-back once the R2 MC AOD->DAOD running is replaced by R3 MC AOD->DAOD running.

CI Result FAILURE (hash 179c4a20)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44094]

Marked as draft, CI errors and open threads. I will change the label

Sergei L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

0d49dc03 - Add Prescales access, disable MB test for the moment

Compare with previous version

An interesting issue ... in runHLT_standalone.py we do not set Input.Files. It flips on now: flags.Trigger.InputContainsConfigMetadata - I see two oprions, set it explicitely to False n runHLTStandalone, make the flag function check if the input is set. Tagging @tamartin @rbielski @fwinkl for opinions.