Switching to new jet config in derivations
This MR attempts to switch to the new config for jet reconstruction in derivations. Here only PHYS is changed. The JETMX formats will follow once this MR is in.
JetCommon
and ExtendedJetCommon
will be deleted as soon as the remaining points (see below) are resolved. The remaining functions that are still needed can be found in JetCommonNewConfig.py
for the time being.
For future MRs:
- make decorationDressing in
ParticleJetToolsConfig.py
configurable? This is not urgent and can come later - Make sure that we use the latest calibrations in the derivations and not the T0 calibration. This will change however the jets in the output so has to be discussed if right now is a good moment for this change.
- [As discussed in JSV meeting today]: New CHS subtraction from commit which requires a new TTVA and is currently enabled via a flag.
Tagging @delsart @wbalunas @mswiatlo @camacho @sawyer @schaarsc @khoo
Merge request reports
Activity
added 849 commits
-
2a415184...9f8d8f34 - 848 commits from branch
atlas:master
- 74f24b5e - updates from master
-
2a415184...9f8d8f34 - 848 commits from branch
added 1 commit
- 505dd6d9 - Remove unused imports and duplicate functions
- Resolved by Chris Malena Delitzsch
- Resolved by Chris Malena Delitzsch
- Resolved by Chris Malena Delitzsch
- Resolved by Chris Malena Delitzsch
- Resolved by Chris Malena Delitzsch
Thanks a lot @cdelitzs for your email pointing to your changes in the b-tagging derivation code. As already commented by @dguest on the MR, and also by @vdao in the email, let me put here a quick record of the discussions:
- btagging in BTaggingContent.py is old and can be removed,
- atm HbbCommon is not called in any derivations since we rely on the VR built from you and associated to the largeR-jets in your jet derivation code.
Cheers, Arnaud
This is super awesome, thank you @cdelitzs !
added 129 commits
-
37c6f1ec...46f27b99 - 128 commits from branch
atlas:master
- c21e6b5f - Pulling changes from master
-
37c6f1ec...46f27b99 - 128 commits from branch
- Resolved by Teng Jian Khoo
- Resolved by William Keaton Balunas
Thanks Chris, this is a great piece of work! My only real comment from a first look through is a suggestion to simplify some of the python tool handling (see my other posts). We may also want to change the name of
JetCommonNewConfig.py
, but that should probably happen at the same time we remove the existingJetCommon.py
.I don't have strong opinions about the CHS WP. If we change the default it will probably necessitate CI updates as well, but that will need to happen eventually anyway if it's going to be the recommendation.
added 615 commits
-
c21e6b5f...765e289f - 612 commits from branch
atlas:master
- 97d5fdeb - cleaning of jet derivation code
- 4bd98e05 - fixes for new jet config
- 24afd2ca - Merge remote-tracking branch 'upstream/master' into master-derivations-new-jet-config
Toggle commit list-
c21e6b5f...765e289f - 612 commits from branch