Skip to content
Snippets Groups Projects

Switching to new jet config in derivations

This MR attempts to switch to the new config for jet reconstruction in derivations. Here only PHYS is changed. The JETMX formats will follow once this MR is in.

JetCommon and ExtendedJetCommon will be deleted as soon as the remaining points (see below) are resolved. The remaining functions that are still needed can be found in JetCommonNewConfig.py for the time being.

For future MRs:

  • make decorationDressing in ParticleJetToolsConfig.py configurable? This is not urgent and can come later
  • Make sure that we use the latest calibrations in the derivations and not the T0 calibration. This will change however the jets in the output so has to be discussed if right now is a good moment for this change.
  • [As discussed in JSV meeting today]: New CHS subtraction from commit which requires a new TTVA and is currently enabled via a flag.

Tagging @delsart @wbalunas @mswiatlo @camacho @sawyer @schaarsc @khoo

Edited by Chris Malena Delitzsch

Merge request reports

Pipeline #3514981 passed

Pipeline passed for 42239d7e on cdelitzs:master-derivations-new-jet-config

Approval is optional
Ready to merge by members who can write to the target branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chris,

    Thanks ! this is a huge work. I've added a few comments above, just to open discussions.

    Cheers, P-A

  • Thanks a lot @cdelitzs for your email pointing to your changes in the b-tagging derivation code. As already commented by @dguest on the MR, and also by @vdao in the email, let me put here a quick record of the discussions:

    • btagging in BTaggingContent.py is old and can be removed,
    • atm HbbCommon is not called in any derivations since we rely on the VR built from you and associated to the largeR-jets in your jet derivation code.

    Cheers, Arnaud

  • This is super awesome, thank you @cdelitzs !

  • added 2 commits

    • 2d9a1bc0 - Schedule truth PJ in EGammaCommon, move EGamma to new config
    • 6395c69a - Delete obselete StandardJetDefs

    Compare with previous version

  • added 2 commits

    • 350609d0 - More changes for switching to new jet config
    • 37c6f1ec - Merge branch 'master-derivations-new-jet-config' of...

    Compare with previous version

  • Chris Malena Delitzsch changed the description

    changed the description

  • Chris Malena Delitzsch resolved all threads

    resolved all threads

  • added 129 commits

    Compare with previous version

  • Thanks Chris, this is a great piece of work! My only real comment from a first look through is a suggestion to simplify some of the python tool handling (see my other posts). We may also want to change the name of JetCommonNewConfig.py, but that should probably happen at the same time we remove the existing JetCommon.py.

    I don't have strong opinions about the CHS WP. If we change the default it will probably necessitate CI updates as well, but that will need to happen eventually anyway if it's going to be the recommendation.

  • added 615 commits

    • c21e6b5f...765e289f - 612 commits from branch atlas:master
    • 97d5fdeb - cleaning of jet derivation code
    • 4bd98e05 - fixes for new jet config
    • 24afd2ca - Merge remote-tracking branch 'upstream/master' into master-derivations-new-jet-config

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading