RecExConfig: Support eventless inputs in autoconfig Fix ATLASRECTS-6708

Streams that do not contain events generate empty EventStreamInfo. If all input files are event-less the metadata peeking returns empty event summaries for the input streams. Autoconfiguration will fail because configuration parameters are dependent on whether events are data or simulation, the name of the input stream, and the input run number. All these would be read from the input EventStreamInfo. These three issues were addressed by adopting three fallbacks:

1. Data vs Simulation: examine the metadata catalog content: simulation parameters, for example, are only available for simulation. Run parameters (ByteStreamMetadata) are only available for data.
2. Input stream name: looked up from the xAOD::FileMetaData
3. Run number: fall back to the RecExConfig default

These decisions were made because they were simple and produced a working configuration. A proper fix would be to make this configuration information available in event-less files (on my to-do list for next year).

Tag: @gemmeren @tsulaia @rmazini @mhodgkin @amete @akraszna

marked this merge request as ready

This merge request affects 3 packages:

• Reconstruction/RecExample/RecExCommon
• Reconstruction/RecExample/RecExConfig
• Tools/PyUtils

Affected files list will not be printed in this case

Adding @goetz as watcher

added JetEtmiss Reconstruction Tools master review-pending-level-1 labels

CI Result FAILURE (hash fdb40428)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44469]

added alsoTargeting:22.0-mc20 label

Set to also target 22.0-mc20 as requested in ATLASRECTS-6757

Hi @berghaus, could you please have a look?

Trigger_athenaHLT-test failure:

..........................................
chainComp INFO       HLT_xe30_trkmht_L1XE30:
chainComp INFO         eventCount: 2 -> 0
chainComp INFO         stepCounts:
chainComp INFO           1: 2 -> 0
chainComp INFO         stepFeatures:
chainComp INFO           1: 2 -> 0
chainComp ERROR    Trigger counts differ from the reference. If the above differences are intended, update the reference
chainComp INFO     Patch file created. To apply, run in the athena source directory:
chainComp INFO     git apply /var/lib/jenkins/workspace/CI-test-driver/CI-test-driver_49279_74195/Athena/Trigger_athenaHLT/test_trigP1_v1Dev_decodeBS_build/ref_v1Dev_decodeBS_build.patch
chainComp INFO     Then check with git diff and, if everything is correct, add and commit

Sergei L1

added review-user-action-required label and removed review-pending-level-1 label

added 2 commits

• 6d1c8a55 - Revert "Fall back to default run number if not in metadata"
• 0c1d4695 - TileConditions: Check RunNumber before assume type int()

Compare with previous version

This merge request affects 4 packages:

• Reconstruction/RecExample/RecExCommon
• Reconstruction/RecExample/RecExConfig
• TileCalorimeter/TileConditions
• Tools/PyUtils

Affected files list will not be printed in this case

Adding @goetz ,@pavol ,@solodkov ,@harkusha as watchers

added Tile review-pending-level-1 labels and removed review-user-action-required label

CI Result SUCCESS (hash 0c1d4695)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44519]

To my understanding, there are open thread still in progress. Removing review-pending-level-1 label while these are boing addressed/resolved. Relabel when ready please.

-- L1

removed review-pending-level-1 label

added review-user-action-required label

mentioned in merge request !49433 (merged)

removed alsoTargeting:22.0-mc20 label

resolved all threads

This merge request affects 4 packages:

• Reconstruction/RecExample/RecExCommon
• Reconstruction/RecExample/RecExConfig
• TileCalorimeter/TileConditions
• Tools/PyUtils

Affected files list will not be printed in this case

Adding @goetz ,@pavol ,@solodkov ,@harkusha as watchers