Remove unused variables from smart slimming lists and EGAM extra content

Cleanup slimming lists for EGAM derivations. Remove non-existent (and unused) variables from the electron and photon smart slimming lists to suppress warnings in the log files.

added Derivation Egamma master labels

requested review from @christos, @jdevivi, and @htorres

added 1 commit

• 85089e50 - remove DensityArea and DensitySigma isolation variables as per JBDV's suggestion

Compare with previous version

Hello. I think this is fine. Just tagging @lpascual also. We should revisit the list of variables to produce and store at some point, for a next MR (next year...)

marked this merge request as ready

changed title from Draft: remove unused variables from smart slimming lists and EGAM extra content to Remove unused variables from smart slimming lists and EGAM extra content

This merge request affects 1 package:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma

This merge request affects 4 files:

• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM10ExtraContent.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/EGAM1ExtraContent.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/ElectronsCPContent.py
• PhysicsAnalysis/DerivationFramework/DerivationFrameworkEGamma/python/PhotonsCPContent.py

added review-pending-level-1 label

CI Result SUCCESS (hash 85089e50)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44498]

resolved all threads

Two suggestions on coding style, otherwise this MR looks good from my perspective.

-- L1

added review-user-action-required label and removed review-pending-level-1 label

Hi @chscheul,

I am working on cleaning up the code including also your suggestions, but I'd rather make those changes in a separate MR focused on code style and keep this MR about removing the unused isolation variables

Thanks, Giovanni

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

Approving -- L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 35592b4e

added sweep:ignore label