Skip to content
Snippets Groups Projects

Run3AFPMonitoring: Avoid repeated storegate retrieves

Merged Adam Edward Barton requested to merge abarton/athena:avoideventinfo into master
All threads resolved!

Retrieving the read handle repeatedly is a waste.

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Johannes ElmsheuserJohannes Elmsheuser 3 years ago (Dec 25, 2021 7:03am UTC)

Merge details

  • Changes merged into master with 1c6abcde (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • b5299d7f - Avoid repeated storegate retrieves

    Compare with previous version

  • Adam Edward Barton resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • ForwardDetectors/AFP/Run3AFPMonitoring

    This merge request affects 2 files:

    • ForwardDetectors/AFP/Run3AFPMonitoring/src/AFPSiLayerAlgorithm.cxx
    • ForwardDetectors/AFP/Run3AFPMonitoring/src/AFPToFAlgorithm.cxx

    Adding @ggach as watcher

  • :white_check_mark: CI Result SUCCESS (hash b5299d7f)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :cloud: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44547]

  • Changes look good and CI clean output clean, approving

  • mentioned in commit 1c6abcde

  • Please register or sign in to reply
    Loading