Skip to content
Snippets Groups Projects

Assure that tag overrides in IOVDbSvc are unique

Merged Assure that tag overrides in IOVDbSvc are unique
tbold/athena:make-overrideTags-ordered-set into master
All threads resolved!
Merged Tomasz Bold requested to merge tbold/athena:make-overrideTags-ordered-set into master
All threads resolved!

While comparing CA JO and rec-ex-common it turned out out the IOVDbSvc.overrideTags is somewhat misconfigured in the old style. Namely, the directives are repeated many times. This makes the config comparisons a bit awkward.

Realy not sure who can be tagged for info. @tadej maybe?

Merge request reports

Pipeline #3382033 passed

Stage: external

    Pipeline passed for 68f54524 on tbold:make-overrideTags-ordered-set

    Approval is optional

    Merged by Edward MoyseEdward Moyse 3 years ago (Jan 11, 2022 3:26pm UTC)

    Merge details

    • Changes merged into master with dbe1020f (commits were squashed).
    • Did not delete the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Chris Scheulen
    Chris Scheulen @chscheul ·
    Developer

    Got a single suggestion here, otherwise this looks good from my perspective.

    -- L1

  • Chris Scheulen added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Tomasz Bold resolved all threads

    resolved all threads

  • Tadej Novak
    Tadej Novak @tadej ·
    Developer

    Hi @tbold, you also have to put back the review-pending-level-1 if you want a MR to proceed :blush:

    Approving now as L2.

  • Tadej Novak added review-approved label and removed review-user-action-required label

    added review-approved label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Database/IOVDbSvc

    This merge request affects 1 file:

    • Database/IOVDbSvc/python/CondDB.py

    Adding @ssnyder as watcher

  • ATLAS Robot added review-pending-level-1 label and removed review-approved label

    added review-pending-level-1 label and removed review-approved label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 68f54524)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :cloud: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44879]

  • Tadej Novak removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Tadej Novak added review-approved label

    added review-approved label

  • Edward Moyse merged

    merged

  • Edward Moyse mentioned in commit dbe1020f

    mentioned in commit dbe1020f

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply