Skip to content
Snippets Groups Projects

InDetValidation clang-tidy related fixes

Merged InDetValidation clang-tidy related fixes
ATLAS-EGamma/athena:InDetValidation_clang into master
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:InDetValidation_clang into master

InDetValidation clang-tidy related fixes

Merge request reports

Pipeline #3386598 passed

Stage: external

    Pipeline passed for ee642964 on ATLAS-EGamma:InDetValidation_clang

    Approval is optional

    Merged by Johannes ElmsheuserJohannes Elmsheuser 3 years ago (Dec 25, 2021 7:07am UTC)

    Merge details

    • Changes merged into master with 17b42d70 (commits were squashed).
    • Deleted the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      This merge request affects 1 package:

      • InnerDetector/InDetValidation/InDetPhysValMonitoring

      This merge request affects 24 files:

      • InnerDetector/InDetValidation/InDetPhysValMonitoring/InDetPhysValMonitoring/InDetPhysValMonitoringTool.h
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/InDetPhysValMonitoring/ResolutionHelper.h
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/AthTruthSelectionTool.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/CachedGetAssocTruth.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/CachedGetAssocTruth.h
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/HistogramDefinitionSvc.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPerfPlot_VertexTruthMatching.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPerfPlot_VertexTruthMatching.h
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPerfPlot_nTracks.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPhysHitDecoratorAlg.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPhysValMonitoringTool.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPhysValTruthDecoratorAlg.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPlotBase.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPlotBase.h
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetRttPlots.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/ReadFromXmlDom.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/ReadFromXmlDom.h
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/ResolutionHelper.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/SingleHistogramDefinition.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/TrackSelectionTool.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/TrackTruthLookup.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/TrackTruthSelectionTool.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/dRMatchingTool.cxx
      • InnerDetector/InDetValidation/InDetPhysValMonitoring/util/postProcessIDPVMHistos.cxx

      Adding @goetz ,@sroe as watchers

    • ATLAS Robot added InnerDetector master review-pending-level-1 labels

      added InnerDetector master review-pending-level-1 labels

    • ATLAS Robot
      ATLAS Robot @atlasbot ·
      Developer

      :white_check_mark: CI Result SUCCESS (hash ee642964)

      Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
      externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark: :cloud: :white_check_mark: :white_check_mark: :white_check_mark:
      make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

      Full details available on this CI monitor view. Check the JIRA CI status board for known problems
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
      :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
      :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
      :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44553]

    • Edson Carquin Lopez
      Edson Carquin Lopez @carquin ·
      Developer

      Review looks good, clear changes, approving

    • Edson Carquin Lopez added review-approved label and removed review-pending-level-1 label

      added review-approved label and removed review-pending-level-1 label

    • Johannes Elmsheuser merged

      merged

    • Johannes Elmsheuser mentioned in commit 17b42d70

      mentioned in commit 17b42d70

    • Atlas Nightlybuild added sweep:ignore label

      added sweep:ignore label

    Please register or sign in to reply