Skip to content
Snippets Groups Projects

SurfaceCache. Allow to store what we need and only what we need for the TRT straw caches.

Merged SurfaceCache. Allow to store what we need and only what we need for the TRT straw caches.
ATLAS-EGamma/athena:TRT_Base_avoid_double_Caching into master
All threads resolved!
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:TRT_Base_avoid_double_Caching into master
All threads resolved!

SurfaceCache. Allow to store what we need and only what we need for the TRT straw caches . ATLASRECTS-3127 part II

Should remove 2 more surplus ptr.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chris Scheulen
    Chris Scheulen @chscheul ·
    Developer

    One point on documentation, looking good otherwise from my perspective.

    -- L1

  • Chris Scheulen added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Christos Anastopoulos added 1 commit

    added 1 commit

    Compare with previous version

  • Christos Anastopoulos resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • InnerDetector/InDetDetDescr/InDetReadoutGeometry
    • InnerDetector/InDetDetDescr/TRT_ReadoutGeometry

    Affected files list will not be printed in this case

    Adding @goetz ,@cgrefe ,@calfayan ,@sroe as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Chris Scheulen resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash ef46794f)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :cloud: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44566]

  • S
    Sergei Rosliakov @seroslia1 ·

    Looks good. Approved

    Sergei L1

  • Sergei Rosliakov added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Johannes Elmsheuser mentioned in commit 81c92378

    mentioned in commit 81c92378

  • Johannes Elmsheuser merged

    merged

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply