Skip to content
Snippets Groups Projects

EM shower shapes try to avoid lookups for cells we already have

Merged EM shower shapes try to avoid lookups for cells we already have
ATLAS-EGamma/athena:egamma_middle_shape_lookup_once into master
All threads resolved!
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:egamma_middle_shape_lookup_once into master
All threads resolved!

EM shower shapes try to avoid lookups for cells we already have

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Chris Scheulen
  • Chris Scheulen
  • Chris Scheulen
  • Chris Scheulen added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Christos Anastopoulos added 1 commit

    added 1 commit

    • 25f3f0ab - Clarify a bit the 2 steps of find the hottest and then open windows wrt the hottest

    Compare with previous version

  • Christos Anastopoulos resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Reconstruction/egamma/egammaCaloUtils

    This merge request affects 2 files:

    • Reconstruction/egamma/egammaCaloUtils/src/egammaBackShape.cxx
    • Reconstruction/egamma/egammaCaloUtils/src/egammaMiddleShape.cxx

    Adding @goetz as watcher

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 25f3f0ab)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :cloud: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44565]

  • S
    Sergei Rosliakov @seroslia1 ·

    Looks good. Approved

    Sergei L1

  • Sergei Rosliakov added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Johannes Elmsheuser mentioned in commit 2c6e77fb

    mentioned in commit 2c6e77fb

  • Johannes Elmsheuser merged

    merged

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply