egammaEnergyCorrectionTool : Fix unchecked dynamic_cast s (Coverity defect)

egammaEnergyCorrectionTool : Fix unchecked dynamic_cast s (Coverity reports that basically we could use ~70 member variables that could be nullptr as we did not check any dynamic_cast ... ).

Basically add an internal "helper" in the anonymous namespace . That does the dynamic_cast and throws if it fails . In the message we can have the name of the TObject we failed to cast from.

WARNING: big files (>100K) are found in the changeset

188K in file PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/Root/egammaEnergyCorrectionTool.cxx

This merge request affects 1 package:

• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection

This merge request affects 1 file:

• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/Root/egammaEnergyCorrectionTool.cxx

added Analysis Egamma analysis-review-required master review-pending-level-1 labels

added 1 commit

• 3cf5659c - Internal helper to check the result of a cast and throw error

Compare with previous version

changed title from egammaEnergyCorrectionTool . Try to rm repetitive code / make sure we check the dynamic cast result to egammaEnergyCorrectionTool . Fix uncheckecked dynamic_casts (Coverity defect)

WARNING: big files (>100K) are found in the changeset

196K in file PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/Root/egammaEnergyCorrectionTool.cxx

This merge request affects 1 package:

• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection

This merge request affects 1 file:

• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/Root/egammaEnergyCorrectionTool.cxx

There were multiple CI triggers for this MR and commit. The system ignored duplicates. However the GitLab pipelines status may be shown incorrectly.

changed the description

added 1 commit

• dc723de4 - add better messages to the runtime error

Compare with previous version

WARNING: big files (>100K) are found in the changeset

196K in file PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/Root/egammaEnergyCorrectionTool.cxx

This merge request affects 1 package:

• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection

This merge request affects 2 files:

• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/Root/EgammaCalibrationAndSmearingTool.cxx
• PhysicsAnalysis/ElectronPhotonID/ElectronPhotonFourMomentumCorrection/Root/egammaEnergyCorrectionTool.cxx

changed title from egammaEnergyCorrectionTool . Fix uncheckecked dynamic_casts (Coverity defect) to egammaEnergyCorrectionTool : Fix unchecked dynamic_casts (Coverity defect)

changed the description

CI Result SUCCESS (hash 99e03ad3)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44827]

changed title from egammaEnergyCorrectionTool : Fix unchecked dynamic_casts (Coverity defect) to egammaEnergyCorrectionTool : Fix unchecked dynamic_cast s (Coverity defect)

changed the description

CI Result SUCCESS (hash 3cf5659c)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44830]

CI Result SUCCESS (hash dc723de4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 44831]

The changes look fine and the CI warnings are unrelated. Approving.

Jason (L1)

added review-approved label and removed review-pending-level-1 label

added analysis-review-approved label and removed analysis-review-required label

mentioned in commit ae0d3bbd

merged

added sweep:ignore label