Skip to content
Snippets Groups Projects

Reorganization of AFP trigger setup

Merged Reorganization of AFP trigger setup
pbalek/athena:afp-reorganize-reco-setup-ATR-24733 into master
All threads resolved!
Merged Petr Balek requested to merge pbalek/athena:afp-reorganize-reco-setup-ATR-24733 into master
All threads resolved!

Reorganization of AFP HLT setup and partially offline setup. Now HLT uses the same methods as offline reconstruction. The python setups are placed in respective AFP_Reconstruction packages, not in TriggerMenuMT anymore; the setup of clustering tool is now in AFP_Reconstruction/AFP_SiClusterTools and not part of AFP track reco setup (AFP_Reconstruction/AFP_LocReco). Moreover, further implementation of monitoring tools for trigger should be easier.

Closes ATR-24733

Edited by Petr Balek

Merge request reports

Pipeline #3489551 passed

Stage: external

Pipeline passed for 77a4335d on pbalek:afp-reorganize-reco-setup-ATR-24733

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 3 years ago (Jan 28, 2022 9:50am UTC)

Merge details

  • Changes merged into master with d1dbdb0e (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Petr Balek added 1 commit

    added 1 commit

    Compare with previous version

  • Petr Balek marked this merge request as ready

    marked this merge request as ready

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 7 packages:

    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_GlobReco
    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_LocReco
    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_SiClusterTools
    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_VertexReco
    • ForwardDetectors/ForwardRec
    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @goetz ,@sutt ,@hrussell ,@okuprash ,@ggach ,@dzanzi ,@bernius as watchers

  • ATLAS Robot added ForwardDetectors Trigger TriggerEDM TriggerMenu TriggerMinBias master review-pending-level-1 labels

    added ForwardDetectors Trigger TriggerEDM TriggerMenu TriggerMinBias master review-pending-level-1 labels

  • Catrin Bernius
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 3d96a78e)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45067]

  • Steffen Korn
    Steffen Korn @skorn ·
    Developer

    Adding user action required label till discussion are resolved.

    Feel free to remove it once you are ready.

    Cheers, Steffen (L1)

  • Steffen Korn removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Steffen Korn added review-user-action-required label

    added review-user-action-required label

  • Petr Balek added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 7 packages:

    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_GlobReco
    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_LocReco
    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_SiClusterTools
    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_VertexReco
    • ForwardDetectors/ForwardRec
    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @goetz ,@sutt ,@hrussell ,@okuprash ,@ggach ,@dzanzi ,@bernius as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash e4a9fd51)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45101]

  • Carlo Varni
    Carlo Varni @cvarni ·
    Developer

    Huge changes in the JO. Moving to L2 for deeper look -- L1

  • Carlo Varni added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • Petr Balek marked this merge request as draft

    marked this merge request as draft

  • Jiri Masik
  • J
    Jakub Kremer @jkremer ·
    Developer

    Removing review-pending-level-2, since the MR has been moved back to draft state.

    Jakub (L1 shifter)

  • Jakub Kremer removed review-pending-level-2 label

    removed review-pending-level-2 label

  • Petr Balek added 1 commit

    added 1 commit

    Compare with previous version

  • Petr Balek added 1 commit

    added 1 commit

    Compare with previous version

  • Petr Balek added 1 commit

    added 1 commit

    Compare with previous version

  • Petr Balek added 1 commit

    added 1 commit

    Compare with previous version

  • Petr Balek added 723 commits

    added 723 commits

    Compare with previous version

    Toggle commit list
  • Petr Balek added 1 commit

    added 1 commit

    Compare with previous version

  • Petr Balek added 1 commit

    added 1 commit

    Compare with previous version

  • Petr Balek added 1 commit

    added 1 commit

    Compare with previous version

  • Petr Balek added 1 commit

    added 1 commit

    Compare with previous version

  • Petr Balek added 1 commit

    added 1 commit

    Compare with previous version

  • Petr Balek marked this merge request as ready

    marked this merge request as ready

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 7 packages:

    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_GlobReco
    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_LocReco
    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_SiClusterTools
    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_VertexReco
    • ForwardDetectors/ForwardRec
    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @goetz ,@sutt ,@hrussell ,@okuprash ,@ggach ,@dzanzi ,@bernius as watchers

  • ATLAS Robot added review-pending-level-1 label

    added review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 77a4335d)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45658]

  • J
    Jakub Kremer @jkremer ·
    Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 7 packages:

    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_GlobReco
    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_LocReco
    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_SiClusterTools
    • ForwardDetectors/AFP/AFP_Reconstruction/AFP_VertexReco
    • ForwardDetectors/ForwardRec
    • Trigger/TriggerCommon/TrigEDMConfig
    • Trigger/TriggerCommon/TriggerMenuMT

    Affected files list will not be printed in this case

    Adding @goetz ,@sutt ,@hrussell ,@okuprash ,@ggach ,@dzanzi ,@bernius as watchers

  • Catrin Bernius resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 77a4335d)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45776]

  • Marianna Liberatore added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Adam Edward Barton merged

    merged

  • Adam Edward Barton mentioned in commit d1dbdb0e

    mentioned in commit d1dbdb0e

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply