Extend tau trigger single leg trigger matching list in DAOD PHYS (ATR-24269)
Issue : looking at two recent DAOD PHYS data/MC samples produced with 22.0.50:
- mc20_13TeV.361108.PowhegPythia8EvtGen_AZNLOCTEQ6L1_Ztautau.deriv.DAOD_PHYS.e3601_s3681_r13144_r13146_p4926
- data18_13TeV.00349481.physics_Main.deriv.DAOD_PHYS.r13286_p4910_p4926
The trigger matching information for single leg tau triggers are missing. The trigger matching info be used for trigger efficiency/scale factor measurement using R22 Run2 reprocessing.
The issue should be caused by different name convention between Run2 and Run3 triggers: Run2 triggers (our target) don't have L1 item in the trigger name, while the single leg tau trigger list used for matching is filled using Run3 trigger name convention (not useful in this context).
This MR is recovering the missing trigger matching information by extending the current single leg tau trigger list used for matching.
Tested using:
- test_data18PHYS_serial.sh
- test_mc16PHYS_serial.sh
Example of output added by this MR for 2018 data period:
302.316 kb 20.893 kb 0.005 kb 14.470 4136 TrigMatch_HLT_tau25_medium1_tracktwoEF (DataVector<xAOD::TrigComposite_v1>) [Trig]
302.316 kb 20.893 kb 0.005 kb 14.470 4136 TrigMatch_HLT_tau35_medium1_tracktwoEF (DataVector<xAOD::TrigComposite_v1>) [Trig]
302.316 kb 20.893 kb 0.005 kb 14.470 4136 TrigMatch_HLT_tau60_medium1_tracktwoEF (DataVector<xAOD::TrigComposite_v1>) [Trig]
Tagging @tamartin, @aranzazu, @jburr, @iriu, @gipezzul, @martindl and @calpigia
Merge request reports
Activity
added Non-ATLAS account label
added Derivation Tau Trigger master review-pending-level-1 labels
CI Result SUCCESS (hash c2b9fc9e)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45196]removed Non-ATLAS account label
- Resolved by Clara Nellist
Changes look good, but putting review-user-action-required back, until remaining comments are addressed.
Jakub (L1 shifter)
added review-user-action-required label and removed review-pending-level-1 label
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash 792ed64c)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45209]added alsoTargeting:21.2 label
added review-approved label and removed review-pending-level-1 label
mentioned in commit bc83da5d
added sweep:done label
picked the changes into the branch
cherry-pick-bc83da5d087-21.2
with commit c0e0823fmentioned in commit c0e0823f
mentioned in merge request !49746 (merged)
Sweep summary
successful:- 21.2
(see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/2157/console for details)
mentioned in commit 4991512a