Skip to content
Snippets Groups Projects

gFEX NtupleWriter update

Merged gFEX NtupleWriter update
ctosciri/athena-old:gFEX_Validation into master
All threads resolved!
Merged Cecilia Tosciri requested to merge ctosciri/athena-old:gFEX_Validation into master
All threads resolved!

Small changes to the gFEX NtupleWriter used for validation purposes. In particular, global variables (total/hard/soft MET components, total MET, scalar energy) and truth jets variables have been included in the output tree created with gFEX NtupleWriter.

Edited by Cecilia Tosciri

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 3 years ago (Jan 21, 2022 6:46pm UTC)

Merge details

  • Changes merged into master with 85d0fde3 (commits were squashed).
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • J
    Jakub Kremer @jkremer ·
    Developer

    Hi @ctosciri, I have just one minor comment, otherwise the changes look good to me.

    Jakub (L1 shifter)

  • Jakub Kremer added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Cecilia Tosciri added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

    This merge request affects 2 files:

    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/L1CaloFEXSim/gFEXNtupleWriter.h
    • Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim/src/gFEXNtupleWriter.cxx

    Adding @serodrig ,@kwhalen ,@afaulkne as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Cecilia Tosciri resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash a258df5c)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45225]

  • Carlo Varni
    Carlo Varni @cvarni ·
    Developer

    Hi @ctosciri the changes look fine from a L1 perspective. Do you mind however to add a few more details in the MR description about these changes?

    -- L1

  • Carlo Varni added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Cecilia Tosciri changed the description

    changed the description

  • C
    Cecilia Tosciri @ctosciri ·
    Author Developer

    Hi @cvarni, I have included few more details, I hope it's fine now. Thank you!

  • C
    Cecilia Tosciri @ctosciri ·
    Author Developer

    Hi @cvarni! Any chance to get this merged before next week? Thanks!

  • Carlo Varni added review-approved label and removed review-user-action-required label

    added review-approved label and removed review-user-action-required label

  • Vakhtang Tsulaia merged

    merged

  • Vakhtang Tsulaia mentioned in commit 85d0fde3

    mentioned in commit 85d0fde3

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply