Add support for enum config flags

Add support for enum config flags, port Input.Format and enable checks also for Common.ProductionStep.

The validation is done on lock and only touches flags that have enum assigned.

Tagging also @mhodgkin as I simplified some PFlow configuration now that the whole chain is running.

/cc @fwinkl @wlampl @tbold @goetz @jchapman @emoyse

added NewConfig full-unit-tests labels

Jenkins please retry a build

This merge request affects 28 packages. Since this is a long list, it will not be printed.

Adding @sutt ,@joheinri ,@kwhalen ,@stavrop ,@mvozak ,@asonay ,@wiedenma ,@rosati ,@cmorenom ,@solodkov ,@bcarlson ,@hrussell ,@nagano ,@fwinkl ,@egodden ,@bernius ,@damazio ,@cantel ,@goetz ,@dzanzi ,@wleight ,@iriu ,@pavol ,@sroe ,@orlando ,@harkusha ,@ssnyder ,@tamartin ,@mark ,@paulama ,@jojungge ,@mhodgkin ,@afaulkne ,@rbielski as watchers

added Analysis Calorimeter Core DQ InnerDetector JetEtmiss LAr MuonSpectrometer Reconstruction Tile Trigger TriggerID TriggerMenu analysis-review-required master labels

CI Result FAILURE (hash 424961fb)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45219]

added 43 commits

• 424961fb...bf658963 - 42 commits from branch atlas:master
• 6841e667 - Add support for enum config flags

Compare with previous version

resolved all threads

Jenkins please retry a build

This merge request affects 28 packages. Since this is a long list, it will not be printed.

Adding @sutt ,@joheinri ,@kwhalen ,@stavrop ,@mvozak ,@asonay ,@wiedenma ,@rosati ,@cmorenom ,@solodkov ,@bcarlson ,@hrussell ,@nagano ,@fwinkl ,@egodden ,@bernius ,@damazio ,@cantel ,@goetz ,@dzanzi ,@wleight ,@iriu ,@pavol ,@sroe ,@orlando ,@harkusha ,@ssnyder ,@tamartin ,@mark ,@paulama ,@jojungge ,@mhodgkin ,@afaulkne ,@rbielski as watchers

mentioned in merge request !49651 (merged)

CI Result FAILURE (hash 6841e667)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45278]

added 125 commits

• 6841e667...d567f6f9 - 124 commits from branch atlas:master
• dbcf477a - Add support for enum config flags

Compare with previous version

Jenkins please retry a build

This merge request affects 28 packages. Since this is a long list, it will not be printed.

Adding @sutt ,@joheinri ,@kwhalen ,@stavrop ,@mvozak ,@asonay ,@wiedenma ,@rosati ,@cmorenom ,@solodkov ,@bcarlson ,@hrussell ,@nagano ,@fwinkl ,@egodden ,@bernius ,@damazio ,@cantel ,@goetz ,@dzanzi ,@wleight ,@iriu ,@pavol ,@sroe ,@orlando ,@harkusha ,@ssnyder ,@tamartin ,@mark ,@paulama ,@jojungge ,@mhodgkin ,@afaulkne ,@rbielski as watchers

CI Result FAILURE (hash dbcf477a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45390]

Some more unit tests need to be fixed. Will do that soon.

added 37 commits

• dbcf477a...160d8212 - 36 commits from branch atlas:master
• 19e2284e - Add support for enum config flags

Compare with previous version

marked this merge request as ready

changed the description

This merge request affects 36 packages. Since this is a long list, it will not be printed.

Adding @sutt ,@joheinri ,@harkusha ,@stavrop ,@mvozak ,@afaulkne ,@asonay ,@wiedenma ,@rosati ,@solodkov ,@jojungge ,@bcarlson ,@hrussell ,@cmorenom ,@nagano ,@fwinkl ,@egodden ,@bernius ,@damazio ,@cantel ,@goetz ,@dzanzi ,@wleight ,@iriu ,@pavol ,@sroe ,@orlando ,@mnowak ,@ssnyder ,@tamartin ,@mark ,@paulama ,@kwhalen ,@mhodgkin ,@tadej ,@rbielski ,@rbianchi as watchers

added Database EDM Tools review-pending-level-1 labels

added 1 commit

• 7eeb8fdc - Add support for enum config flags

Compare with previous version

This merge request affects 36 packages. Since this is a long list, it will not be printed.

Adding @sutt ,@joheinri ,@harkusha ,@stavrop ,@mvozak ,@afaulkne ,@asonay ,@wiedenma ,@rosati ,@solodkov ,@jojungge ,@bcarlson ,@hrussell ,@cmorenom ,@nagano ,@fwinkl ,@egodden ,@bernius ,@damazio ,@cantel ,@goetz ,@dzanzi ,@wleight ,@iriu ,@pavol ,@sroe ,@orlando ,@mnowak ,@ssnyder ,@tamartin ,@mark ,@paulama ,@kwhalen ,@mhodgkin ,@tadej ,@rbielski ,@rbianchi as watchers

CI Result FAILURE (hash 19e2284e)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45459]

CI Result SUCCESS (hash 7eeb8fdc)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45468]

Marking urgent as it may cause conflicts or unwanted unit test failures if waiting too long.

added urgent label

Given the extent of these changes, I'm passing this to L2.

Jason (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

added review-user-action-required label and removed review-pending-level-2 label

Please check for a possible typo. Otherwise changes look good to me and can be approved. Sergio (L2)

added review-approved label and removed review-user-action-required label

resolved all threads

mentioned in commit ed96dc2b

merged

added sweep:ignore label