Skip to content
Snippets Groups Projects

Fix issue with the Acts refitting

Merged Fix issue with the Acts refitting
corentin/athena:fix-Refitting into master
All threads resolved!
Merged Corentin Allaire requested to merge corentin/athena:fix-Refitting into master
All threads resolved!

This MR fix a few issue that appeared with the switch to Acts version 15 and update a few of the JO (mostly by adding path to a reference material map on eos).

Merge request reports

Pipeline #3468516 passed

Stage: external

    Pipeline passed for 5f15c67b on corentin:fix-Refitting

    Approval is optional

    Merged by Vakhtang TsulaiaVakhtang Tsulaia 3 years ago (Jan 21, 2022 6:21pm UTC)

    Merge details

    • Changes merged into master with 34f8d9b9 (commits were squashed).
    • Did not delete the source branch.

    Activity

    Filter activity
    • Approvals
    • Assignees & reviewers
    • Comments (from bots)
    • Comments (from users)
    • Commits & branches
    • Edits
    • Labels
    • Lock status
    • Mentions
    • Merge request status
    • Tracking
  • Corentin Allaire added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • Tracking/Acts/ActsGeometry
    • Tracking/Acts/ActsTrkFitting

    Affected files list will not be printed in this case

    Adding @amorley ,@cvarni ,@pagessin as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash ad22b016)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45345]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 5f15c67b)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45352]

  • Carlo Varni resolved all threads

    resolved all threads

  • Carlo Varni
  • Carlo Varni
  • Carlo Varni added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Carlo Varni resolved all threads

    resolved all threads

  • Carlo Varni
    Carlo Varni @cvarni ·
    Developer

    Changes look good to me. Approving -- L1

  • Carlo Varni added review-approved label and removed review-user-action-required label

    added review-approved label and removed review-user-action-required label

  • Vakhtang Tsulaia merged

    merged

  • Vakhtang Tsulaia mentioned in commit 34f8d9b9

    mentioned in commit 34f8d9b9

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply