remove uneccesary fullscan Roi flag

The fullscan flag is not needed here - it is really an abuse of the Roi descriptor to use an Roi with different parameters where those parameters are used and still have it as a fullscan Roi.

This removes the fullscan flag, and just uses a standard RoiDescriptor. This will add around 1 ms to the SCT and Pixel RegionSelector calls, but should have otherwise no impact.

If saving that 1 ms in the FS tracking instance taking ~ 600 ms is seen to be important we can modify the SCT and Pixel data preparation to cache the full module list so that the RS doesn';t need to be called at all, and then this will save around 7 ms overall which would be a better solution.

This is only a temporary change however, since the affected code should be moved to the Roi creator, so this change is just to remove the unwanted method from the RoiDescriptor so that it isn't forgotten.

WARNING: big files (>100K) are found in the changeset

136K in file Trigger/TrigAlgorithms/TrigFastTrackFinder/src/TrigFastTrackFinder.cxx

This merge request affects 2 packages:

• DetectorDescription/RoiDescriptor
• Trigger/TrigAlgorithms/TrigFastTrackFinder

Affected files list will not be printed in this case

Adding @stavrop ,@sutt ,@nagano ,@rbianchi ,@jojungge as watchers

added Geometry Trigger TriggerID analysis-review-required master review-pending-level-1 labels

CI Result SUCCESS (hash c244d61f)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45370]

Only a minor comment from my side on this MR -- L1

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

looks good to me. Approving -- L1

added review-approved label and removed review-user-action-required label

Many thanks Carlo

Cheers Mark

Hi, since this changes the RoiDescriptor header, then in order to make use of the changes for further development requires a full nightly build, so if we can have this merged soon that would be great.

Cheers Mark

I have been waiting for the analysis-review-approved label, but I think it's OK to go ahead and merge it now, given its urgency.

merged

mentioned in commit a66ff692

added sweep:ignore label