MuonCombinedReconstruction - Split a bunch of decorations from the CreatorTool into dedicated algs
Hi everybody,
this MR is a kind of clean-up of the MuonCreatorTool
. Apart from the creation of the MuonContainer
and the corresponding combined muon track container, the MuonCreatorTool
also adds lots of extra decorations to the particles which are not necessarily part of the core muon data. There was nothing wrong in doing this way, but given that we will store a common MSOE
track collection for standard & LRT muons quite soon -- just because the LRT version is a simple copy -- things might become a bit messy, for the handling of the AEOT
decorations.
So I started to break these extra decorations apart into separate small algorithms that put into the new MuonCombinedDecorationAlgs
package and removed the corresponding bits from the MuonCreatorTool
.
-
MuonRpcTimingDecorAlg
: Decorate the rpcHit positions, times & identifiers to the muon particle -- currently not configured, but I vaguely remember there was some request to reenable this. -
MuonTrkIDMSScatterDecorAlg
: Decorate the scattering angles of the first and second muon. -
MuonTrkAEOTDecorationAlg
: Decorate theAEOT
to the muon trackParticles -
MuonPrecisionLayerDecorAlg
: Calculate the number of good precision layers based on theAEOT
s
Tagging; @wleight
Merge request reports
Activity
This merge request affects 3 packages:
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedDecorationAlgs
- Reconstruction/MuonIdentification/MuonCombinedRecExample
Affected files list will not be printed in this case
Adding @goetz ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
added Reconstruction master review-pending-level-1 labels
added Run2-DataReco-output-changed Run2-MCReco-output-changed labels
CI Result FAILURE (hash b2a5a4fa)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45471]This merge request affects 3 packages:
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedDecorationAlgs
- Reconstruction/MuonIdentification/MuonCombinedRecExample
Affected files list will not be printed in this case
Adding @goetz ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
This merge request affects 4 packages:
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedDecorationAlgs
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Tools/PROCTools
Affected files list will not be printed in this case
Adding @goetz ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
added Tools label
CI Result FAILURE (hash 571fb61c)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45478] CI Result SUCCESS (hash ea66d451)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45479]This merge request affects 4 packages:
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedDecorationAlgs
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Tools/PROCTools
Affected files list will not be printed in this case
Adding @goetz ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
removed review-pending-level-1 label
added 95 commits
-
ea66d451...ac051ae2 - 93 commits from branch
atlas:master
- 7541ab28 - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into AEOT_Alg
- 8d578dea - Add CA configuration
-
ea66d451...ac051ae2 - 93 commits from branch
CI Result FAILURE (hash ea66d451)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45576]added 108 commits
-
8d578dea...e53e804e - 106 commits from branch
atlas:master
- 61eacecd - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into AEOT_Alg
- 5bfbd0cc - Update ref file
-
8d578dea...e53e804e - 106 commits from branch
This merge request affects 5 packages:
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedConfig
- Reconstruction/MuonIdentification/MuonCombinedDecorationAlgs
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Tools/PROCTools
Affected files list will not be printed in this case
Adding @goetz ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
CI Result FAILURE (hash 5bfbd0cc)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45644]added 113 commits
-
5bfbd0cc...31ab46a0 - 111 commits from branch
atlas:master
- d9dffb6b - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into AEOT_Alg
- 36dd3a18 - Fix warning
-
5bfbd0cc...31ab46a0 - 111 commits from branch
This merge request affects 5 packages:
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedConfig
- Reconstruction/MuonIdentification/MuonCombinedDecorationAlgs
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Tools/PROCTools
Affected files list will not be printed in this case
Adding @goetz ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
CI Result FAILURE (hash 36dd3a18)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45761]This merge request affects 5 packages:
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedConfig
- Reconstruction/MuonIdentification/MuonCombinedDecorationAlgs
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Tools/PROCTools
Affected files list will not be printed in this case
Adding @goetz ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
CI Result FAILURE (hash 4839de7b)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45783]This merge request affects 5 packages:
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedConfig
- Reconstruction/MuonIdentification/MuonCombinedDecorationAlgs
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Tools/PROCTools
Affected files list will not be printed in this case
Adding @goetz ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
CI Result FAILURE (hash 2e59cae1)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45831]This merge request affects 5 packages:
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedConfig
- Reconstruction/MuonIdentification/MuonCombinedDecorationAlgs
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Tools/PROCTools
Affected files list will not be printed in this case
Adding @goetz ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
mentioned in merge request !50080 (closed)
added review-pending-level-1 label
added Run2-FullSim-output-changed label
CI Result FAILURE (hash 2e59cae1)Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 45981]