MuonCombinedReconstruction - A single MSOE container for standard & LRT muons
Hi everybody,
as explained in ATLASRECTS-6787, the MSOnlyExtrapolatedTrackParticles are the same objects between standard & LRT muon tracks but copied into different output containers. The MuonCreatorAlg creates at the same time the Extrapolated, Combined, MSOE track particle container. The creation of the first two is needed as the tracks from the MuGirl and the MuIdCo stream are merged together. The extrapolated tracks from the MuonCandidates are pushed in the vast majority of the cases into the MSOETrackContainer and only for StandAlone muons this track is declared as an extrapolated track particle. In order, to have distinct track collections for each muon track type, the MSOE track container is also created by the MuonCreatorAlg. However, the ID track links already point to two containers. Once to the ordinary container and once to the InDetTrackParticlesFwd container for SAF muons. There is no reason why in one case, the policy of having one container per partilce type shall be respected and in the other not.
Keeping the long tail short, in this MR, the creation of the MSOE TrackParticleContainer is pulled out from the MuonCreatorAlg. The MuonCandidates created by the MuonCombinedCandidateAlg are first converted into xAOD::TrackParticles using the standard conversion algorithm and then the xAOD::TrackParticles are linked to each MuonCandidate by the MuonCandidatexAODParticleLinkAlg which is then fed to the combined reconstruction chain downstream.
The MSOnlyExtrapolatedLocation property is removed from the MuonCreatorAlg and the offline & trigger configuration is adapted. Let me tag the trigger folks @sshaw, @cdiez to check the changes in the trigger configuration as experts.
This MR should not go in before !49867 (merged).
Tagging: @wleight
Closes ATLASRECTS-6787
Merge request reports
Activity
added full-unit-tests label
This merge request affects 8 packages:
- Reconstruction/MuonIdentification/MuonCombinedAlgs
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedConfig
- Reconstruction/MuonIdentification/MuonCombinedEvent
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Reconstruction/MuonIdentification/MuonCombinedToolInterfaces
- Tools/PROCTools
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @goetz ,@sutt ,@rosati ,@wleight ,@stavrop ,@dzanzi ,@jojungge ,@hrussell ,@egodden ,@bernius as watchers
added Reconstruction Tools Trigger TriggerMenu master review-pending-level-1 labels
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals 
cmake make required tests 
optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added 22 commits
-
23a78382...5767ea4f - 20 commits from branch
atlas:master - 50679dbb - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into ATLASRECTS-6787_VolII
- b33e5015 - Fix tests
-
23a78382...5767ea4f - 20 commits from branch
removed Run2-DataReco-output-changed label
removed Run2-MCReco-output-changed label
removed Run2-FullSim-output-changed label
-
This merge request affects 8 packages:
- Reconstruction/MuonIdentification/MuonCombinedAlgs
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedConfig
- Reconstruction/MuonIdentification/MuonCombinedEvent
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Reconstruction/MuonIdentification/MuonCombinedToolInterfaces
- Tools/PROCTools
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @goetz ,@sutt ,@rosati ,@wleight ,@stavrop ,@dzanzi ,@jojungge ,@hrussell ,@egodden ,@bernius as watchers
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
628 628 TrackSteering=CfgGetter.getPublicToolClone("TrigMuonTrackSteering", "MuonTrackSteering"), 629 629 MonTool = MuPatTrackBuilderMonitoring("MuPatTrackBuilderMonitoringSA_"+name)) 630 630 xAODTrackParticleCnvAlg = MuonStandaloneTrackParticleCnvAlg("TrigMuonStandaloneTrackParticleCnvAlg_"+name) 631 theMuonCandidateAlg=MuonCombinedMuonCandidateAlg("TrigMuonCandidateAlg_"+name) 631 632 theMuonCandidateAlg = MuonCombinedMuonCandidateAlg("TrigMuonCandidateAlg_"+name) 633 634 635 MSOExAODTrkPatricleCnvAlg = MuonStandaloneTrackParticleCnvAlg("TrigMSOnlyExtrapolatedTracksConvAlg_"+name, 636 TrackContainerName = str(theMuonCandidateAlg.MuonCandidateLocation), changed this line in version 4 of the diff
removed Run2-FullSim-output-changed label
Dropping Run2-FullSim-output-changed label, which was only added because !50085 (merged) had not yet been merged. This should not reappear now.
Changing label to review-user-action-required until the discussions are resolved. Clara (L1)
added review-user-action-required label and removed review-pending-level-1 label
added 69 commits
-
b33e5015...b8d468df - 68 commits from branch
atlas:master - 85afe7c7 - Merge branch 'master' into 'ATLASRECTS-6787_VolII'
-
b33e5015...b8d468df - 68 commits from branch
-
This merge request affects 8 packages:
- Reconstruction/MuonIdentification/MuonCombinedAlgs
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedConfig
- Reconstruction/MuonIdentification/MuonCombinedEvent
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Reconstruction/MuonIdentification/MuonCombinedToolInterfaces
- Tools/PROCTools
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @goetz ,@sutt ,@rosati ,@wleight ,@stavrop ,@dzanzi ,@jojungge ,@hrussell ,@egodden ,@bernius as watchers
added review-pending-level-1 label and removed review-user-action-required label
-
This merge request affects 8 packages:
- Reconstruction/MuonIdentification/MuonCombinedAlgs
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedConfig
- Reconstruction/MuonIdentification/MuonCombinedEvent
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Reconstruction/MuonIdentification/MuonCombinedToolInterfaces
- Tools/PROCTools
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @goetz ,@sutt ,@rosati ,@wleight ,@stavrop ,@dzanzi ,@jojungge ,@hrussell ,@egodden ,@bernius as watchers
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Hi @jojungge, several CI tests are failing for different reasons, including a stall (e.g.) in
Trigger_athena_data-test. Can you check what is going on?-- L1
added review-user-action-required label and removed review-pending-level-1 label
removed review-user-action-required label
added 126 commits
-
12fe28ac...4532bc27 - 124 commits from branch
atlas:master - 9f808381 - Synchronize the CreatorTool
- 44815e3f - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into ATLASRECTS-6787_VolII
-
12fe28ac...4532bc27 - 124 commits from branch
removed full-unit-tests label
-
This merge request affects 8 packages:
- Reconstruction/MuonIdentification/MuonCombinedAlgs
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedConfig
- Reconstruction/MuonIdentification/MuonCombinedEvent
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Reconstruction/MuonIdentification/MuonCombinedToolInterfaces
- Tools/PROCTools
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @goetz ,@sutt ,@rosati ,@wleight ,@stavrop ,@dzanzi ,@jojungge ,@hrussell ,@egodden ,@bernius as watchers
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added 1 commit
- a1d148e4 - Use central method to look up the track collections
-
This merge request affects 8 packages:
- Reconstruction/MuonIdentification/MuonCombinedAlgs
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedConfig
- Reconstruction/MuonIdentification/MuonCombinedEvent
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Reconstruction/MuonIdentification/MuonCombinedToolInterfaces
- Tools/PROCTools
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @goetz ,@sutt ,@rosati ,@wleight ,@stavrop ,@dzanzi ,@jojungge ,@hrussell ,@egodden ,@bernius as watchers
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
-
This merge request affects 8 packages:
- Reconstruction/MuonIdentification/MuonCombinedAlgs
- Reconstruction/MuonIdentification/MuonCombinedBaseTools
- Reconstruction/MuonIdentification/MuonCombinedConfig
- Reconstruction/MuonIdentification/MuonCombinedEvent
- Reconstruction/MuonIdentification/MuonCombinedRecExample
- Reconstruction/MuonIdentification/MuonCombinedToolInterfaces
- Tools/PROCTools
- Trigger/TriggerCommon/TriggerMenuMT
Affected files list will not be printed in this case
Adding @goetz ,@sutt ,@rosati ,@wleight ,@stavrop ,@dzanzi ,@jojungge ,@hrussell ,@egodden ,@bernius as watchers
