RDBAccessSvc: fixed P1 geometry DB consistency check

Some recent changes in the RDBAccessSvc afected the P1 geometry DB consistency check Algorithm, which has been silently failing without doing any useful checks, and without proper reporting of the failure either.

The issue was addressed by fixing database transaction management inside RDBAccessSvc.

This merge request affects 1 package:

• Database/RDBAccessSvc

This merge request affects 4 files:

• Database/RDBAccessSvc/src/RDBAccessSvc.cxx
• Database/RDBAccessSvc/src/RDBAccessSvc.h
• Database/RDBAccessSvc/src/SourceCompAlg.cxx
• Database/RDBAccessSvc/src/SourceCompAlg.h

Adding @ssnyder as watcher

added Database master review-pending-level-1 labels

CI Result SUCCESS (hash a3846fb8)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 46678]

Changes look good from L1 perspective - approving.

Jakub (L1 shifter)

added review-approved label and removed review-pending-level-1 label

mentioned in commit f599f91a

merged

added sweep:ignore label