CITest: migrate Trigger_athena_MC test

This merge request affects 1 package:

AtlasTest/CITest

This merge request affects 1 file:

AtlasTest/CITest/Athena.cmake

Adding @fwinkl as watcher

added Test analysis-review-required master review-pending-level-1 labels

added Trigger label

removed analysis-review-required label

added analysis-review-expert label

added analysis-review-approved label and removed analysis-review-expert label

CI Result SUCCESS (hash 12c3a671)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 46887]

removed review-pending-level-1 label

added review-user-action-required label

Jenkins please retry a build

This merge request affects 1 package:

AtlasTest/CITest

This merge request affects 1 file:

AtlasTest/CITest/Athena.cmake

Adding @fwinkl as watcher

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 12c3a671)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 46978]

The successful CI looks good, but of course it's the fail modes which are the most important and when people start looking at logs. I agree with the strategy of keeping old and new version running together for a few days, but it's very important we look at some pipelines where the test fails during this time. In particular, the three fail modes which are the most common and the most important:

counts reference mismatch
athena step fails with non-zero code
athena step succeeds but CheckLog finds errors in the log

In particular, does this logic still hold in the new system?
https://gitlab.cern.ch/atlas/athena/-/blob/master/Trigger/TrigValidation/TrigValTools/python/TrigValSteering/Common.py#L89-91
We rely on this in three places for CI-specific behaviour:
https://acode-browser1.usatlas.bnl.gov/lxr/search?%21v=head&_filestring=&_string=running_in_CI
Judging by the --noRoot --noPS in the RootComp command, I think it does still work fine, so it's good. But I'd still like to see what happens when we print the full log on errors.

@rbielski, yes we'll wait for a few failures before disabling the old test. The overall test success/failure is of course determined by the test script itself, which hasn't changed (apart from removing the runTrigCI.py wrapper).

I wasn't aware we are using $gitlabTargetBranch. But it's set by Jenkins so no change there either. However, if people are re-running the CI tests locally they won't have this variable set. From the current uses though it seems it won't matter much.

Just to note that Jenkins makes available 5 git specific variables for 'old' and 'test' frameworks:

gitlabMergeRequestId
gitlabMergeRequestIid
gitlabTargetNamespace
gitlabTargetRepoName
gitlabTargetBranch

Of course, no problem to keep this test in both systems, particularly when problems with {{CITest_OverlayTier0}} test are not completely understood ATLINFR-4423.