Skip to content
Snippets Groups Projects

FastCaloSim shower shape tuning to data

Merged FastCaloSim shower shape tuning to data
jbeirer/athena:21.0-showerShapeDataTuning into 21.0
All threads resolved!
Merged Joshua Falco Beirer requested to merge jbeirer/athena:21.0-showerShapeDataTuning into 21.0
All threads resolved!

This MR adds a class for the FastCaloSim lateral shower shape tuning to data. It implements the 2D eta_s - phi_s scaling model for the layer 2 tuning as well as the cubic series model for the layer 1 tuning of shower shape variables as described in the PUB note. It also implements the loading of the respective model parameters.

Edited by Joshua Falco Beirer

Merge request reports

Pipeline #3611819 passed

Stage: external

Pipeline passed for ecf9ccd7 on jbeirer:21.0-showerShapeDataTuning

Merged by Rachid MaziniRachid Mazini 3 years ago (Feb 23, 2022 5:55pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Joshua Falco Beirer mentioned in merge request !50611 (merged)

    mentioned in merge request !50611 (merged)

  • Joshua Falco Beirer added 1 commit

    added 1 commit

    • f78aa81b - Revert changes to TFCSEnergyInterpolationPiecewiseLinear

    Compare with previous version

  • Joshua Falco Beirer added 1 commit

    added 1 commit

    • 20eccf0b - Revert changes to TFCSEnergyInterpolationPiecewiseLinear

    Compare with previous version

  • Joshua Falco Beirer resolved all threads

    resolved all threads

  • Joshua Falco Beirer marked this merge request as ready

    marked this merge request as ready

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 4 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSLateralShapeTuning.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSLateralShapeTuning.cxx

    Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc as watchers

  • ATLAS Robot added review-pending-level-1 label

    added review-pending-level-1 label

  • Joshua Falco Beirer changed the description

    changed the description

  • Joshua Falco Beirer removed review-pending-level-1 label

    removed review-pending-level-1 label

  • Volker Andreas Austrup added review-user-action-required label

    added review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 20eccf0b)

    Athena AthDataQuality AthSimulation
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :cloud: :cloud: :cloud:
    make :o: :warning: :warning:
    required tests :o: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :o: Athena: number of compilation errors 1, warnings 173
    :warning: AthDataQuality: number of compilation errors 0, warnings 2
    :warning: AthSimulation: number of compilation errors 0, warnings 7
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 47365]

  • Joshua Falco Beirer added 1 commit

    added 1 commit

    • 54edcc23 - Pass path to model parameters as string

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 4 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSLateralShapeTuning.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSLateralShapeTuning.cxx

    Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 54edcc23)

    Athena AthDataQuality AthSimulation
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :cloud: :cloud: :cloud:
    make :warning: :warning: :warning:
    required tests :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :warning: Athena: number of compilation errors 0, warnings 166
    :warning: AthDataQuality: number of compilation errors 0, warnings 2
    :warning: AthSimulation: number of compilation errors 0, warnings 7
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 47394]

  • Carlo Varni
  • Carlo Varni
  • Carlo Varni
  • Carlo Varni added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Joshua Falco Beirer added 1 commit

    added 1 commit

    • 445e622e - Make interpolation objects shared pointers

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 4 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSLateralShapeTuning.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSLateralShapeTuning.cxx

    Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Joshua Falco Beirer added 1 commit

    added 1 commit

    • ecf9ccd7 - Make sure modelParametersFile is closed properly

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 4 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSLateralShapeTuning.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSLateralShapeTuning.cxx

    Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@tadej ,@schaarsc as watchers

  • Joshua Falco Beirer resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 445e622e)

    Athena AthDataQuality AthSimulation
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :cloud: :cloud: :cloud:
    make :warning: :warning: :warning:
    required tests :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :warning: Athena: number of compilation errors 0, warnings 166
    :warning: AthDataQuality: number of compilation errors 0, warnings 2
    :warning: AthSimulation: number of compilation errors 0, warnings 7
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 47435]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash ecf9ccd7)

    Athena AthDataQuality AthSimulation
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :cloud: :cloud: :cloud:
    make :warning: :warning: :warning:
    required tests :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :warning: Athena: number of compilation errors 0, warnings 166
    :warning: AthDataQuality: number of compilation errors 0, warnings 2
    :warning: AthSimulation: number of compilation errors 0, warnings 7
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 47437]

  • M
    Martin Habedank @mhabedan ·
    Developer

    MR looks good, CI passed. Approving.

    Cheers, Martin (L1)

  • Martin Habedank added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Joshua Falco Beirer
    Joshua Falco Beirer @jbeirer ·
    Author Developer

    Hi @rmazini,

    could this please be merged for the next nightly?

    Many thanks!

    Joshua

  • Rachid Mazini mentioned in commit bce51826

    mentioned in commit bce51826

  • Rachid Mazini merged

    merged

  • Atlas Nightlybuild added sweep:done label

    added sweep:done label

  • Atlas Nightlybuild picked the changes into the branch cherry-pick-bce518261d4-master with commit 924ea38f

    picked the changes into the branch cherry-pick-bce518261d4-master with commit 924ea38f

  • Rachid Mazini mentioned in commit 924ea38f

    mentioned in commit 924ea38f

  • A
    Atlas Nightlybuild @atnight ·
    Maintainer

    Sweep summary
    successful:

    • master

    (see https://aiatlas154.cern.ch/jenkins/job/auto_git_sweeps/2301/console for details)

  • Atlas Nightlybuild mentioned in merge request !50725 (merged)

    mentioned in merge request !50725 (merged)

  • Joshua Falco Beirer mentioned in merge request !50775 (merged)

    mentioned in merge request !50775 (merged)

  • Atlas Nightlybuild mentioned in commit 0099ae3c

    mentioned in commit 0099ae3c

  • Adam Edward Barton mentioned in commit 15644adb

    mentioned in commit 15644adb

    • Please register or sign in to reply