Skip to content
Snippets Groups Projects

Enable scheduling of reco jets in IDPVM standalone

All threads resolved!

This MR enables the scheduling of reco small-R jet finding in standalone IDPVM jobs if these jets are required by the IDPVM run (e.g. sum(pt,w) ) and not present. Based on work by @tstreble.

May need some cleaning up / tuning. CC @gfrattar @pbhattar @kostyuk @keli @tstreble @vcairo @gfacini @sroe @goetz in case of comments.

Edited by Maximilian Emanuel Goblirsch-Kolb

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 25ddf1f9 - update The Copyright Message to avoid L1 trouble

    Compare with previous version

  • added 165 commits

    • 25ddf1f9...0e21d686 - 164 commits from branch atlas:master
    • 4011fc7c - Merge remote-tracking branch 'upstream/master' into AddRecoJetsIDPVM

    Compare with previous version

  • added 3 commits

    Compare with previous version

  • resolved all threads

  • Maximilian Emanuel Goblirsch-Kolb marked this merge request as ready

    marked this merge request as ready

  • This merge request affects 2 packages:

    • InnerDetector/InDetRecTools/InDetHardScatterSelectionTool
    • InnerDetector/InDetValidation/InDetPhysValMonitoring

    Affected files list will not be printed in this case

    Adding @goetz ,@amorley ,@sroe as watchers

  • Reverted to AntiKt4EMTopoJets after consultation with experts (thanks @mswiatlo for the useful feedback!), solved the philosopher, this MR is ready to go

  • Amazing stuff. Thank you @goblirsc

  • the code looks fine from L1 perspective. Once the above threads are resolved, it should be approved.

    Roman(L1)

  • added 1 commit

    • 61c790e9 - trying to satisfy jenkins. Delaying a MR 24h on a copyright message seems...

    Compare with previous version

  • This merge request affects 2 packages:

    • InnerDetector/InDetRecTools/InDetHardScatterSelectionTool
    • InnerDetector/InDetValidation/InDetPhysValMonitoring

    Affected files list will not be printed in this case

    Adding @goetz ,@amorley ,@sroe as watchers

  • added 1 commit

    Compare with previous version

  • This merge request affects 2 packages:

    • InnerDetector/InDetRecTools/InDetHardScatterSelectionTool
    • InnerDetector/InDetValidation/InDetPhysValMonitoring

    Affected files list will not be printed in this case

    Adding @goetz ,@amorley ,@sroe as watchers

  • :white_check_mark: CI Result SUCCESS (hash 9798c190)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 48927]

  • :white_check_mark: CI Result SUCCESS (hash 61c790e9)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 48926]

  • resolved all threads

  • based on above and CI passed, approving.

    Roman(L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit c0de75f0

  • Please register or sign in to reply
    Loading