New way to find the point on hit segment closest to the nearest wire
sTGC time response is parametrized in terms of the distance of smallest approach. So digit time indicates to some accuracy the distance between the wire and the hit. The position where this distance intersects the wire is the position charge is induced on the wire, strip and pad channels. Since the sTGC channels are staggered, it is important to determine this position correctly. Then combining the measurements of all layers would improve the resolution. This merge request introduces a new method to compute the smallest distance between the hit and wire, and determine the two points (on the hit segment and on the wire) where distance is smallest.
Merge request reports
Activity
This merge request affects 1 package:
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
This merge request affects 4 files:
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/sTGC_Digitization/sTgcDigitMaker.h
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/sTGC_Digitization/sTgcDigitizationTool.h
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitMaker.cxx
- MuonSpectrometer/MuonDigitization/sTGC_Digitization/src/sTgcDigitizationTool.cxx
Adding @jchapman ,@rosati ,@wleight ,@stavrop ,@jojungge ,@egodden as watchers
added Digitization MuonSpectrometer master review-pending-level-1 labels
CI Result FAILUREAthena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake N/A N/A N/A N/A N/A N/A make N/A N/A N/A N/A N/A N/A required tests N/A N/A N/A N/A N/A N/A optional tests N/A N/A N/A N/A N/A N/A Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 48689]- Resolved by Chav Chhiv Chau
- Resolved by Chav Chhiv Chau
- Resolved by Chav Chhiv Chau
- Resolved by Johannes Junggeburth
- Resolved by Chav Chhiv Chau
- Resolved by Chav Chhiv Chau
- Resolved by Chav Chhiv Chau
- Resolved by Chav Chhiv Chau
- Resolved by Chav Chhiv Chau
- Resolved by Chav Chhiv Chau
- Resolved by Johannes Junggeburth
- Resolved by Chav Chhiv Chau
- Resolved by Chav Chhiv Chau
- Resolved by Johannes Junggeburth
- Resolved by Chav Chhiv Chau
- Resolved by Chav Chhiv Chau
Hi @chchau,
thanks for providing the MR. I've made a couple of comments. All of them are just code styling to make the code more compact. Feel free to reject them if you don't want to trigger a new CI