TrackStateOnSurface: finalize move to all unique_ptr ctors

• TrackStateOnSurface: finalize move to all unique_ptr ctors. Remove the "legacy" ones
• As intermediate commits run clang-tidy on the client packages touched.

ping @sroe

This merge request affects 1 package:

• Tracking/TrkEvent/TrkTrack

This merge request affects 3 files:

• Tracking/TrkEvent/TrkTrack/TrkTrack/TrackStateOnSurface.h
• Tracking/TrkEvent/TrkTrack/TrkTrack/TrackStateOnSurface.icc
• Tracking/TrkEvent/TrkTrack/src/TrackStateOnSurface.cxx

Adding @amorley as watcher

added Tracking master review-pending-level-1 labels

CI Result FAILURE (hash 8a207aab)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 11, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 48810]

marked this merge request as draft

marked this merge request as ready

added 2 commits

• 210d2057 - start migrating remaining clients
• 66658c39 - Add a clang-tidy pass

Compare with previous version

WARNING: big files (>100K) are found in the changeset

264K in file Tracking/TrkExtrapolation/TrkExTools/src/Extrapolator.cxx

292K in file Tracking/TrkFitter/TrkGlobalChi2Fitter/src/GlobalChi2Fitter.cxx

This merge request affects 8 packages:

• HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecTools/HGTD_TrackTimeExtensionTools
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
• Reconstruction/MuonIdentification/MuidCaloScatteringTools
• Tracking/TrkEvent/TrkTrack
• Tracking/TrkEventCnv/TrkEventTPCnv
• Tracking/TrkExtrapolation/TrkExTools
• Tracking/TrkFitter/TrkGlobalChi2Fitter
• Tracking/TrkVertexFitter/TrkVertexFitters

Affected files list will not be printed in this case

Adding @goetz ,@rosati ,@dshope ,@wleight ,@cohm ,@stavrop ,@amorley ,@jojungge ,@egodden ,@lshan as watchers

added HGTD JetEtmiss MuonSpectrometer Reconstruction labels

added 1 commit

• 6a1e9b73 - update more clients

Compare with previous version

WARNING: big files (>100K) are found in the changeset

264K in file Tracking/TrkExtrapolation/TrkExTools/src/Extrapolator.cxx

292K in file Tracking/TrkFitter/TrkGlobalChi2Fitter/src/GlobalChi2Fitter.cxx

This merge request affects 11 packages:

• HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecTools/HGTD_TrackTimeExtensionTools
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
• Reconstruction/MuonIdentification/MuidCaloEnergyTools
• Reconstruction/MuonIdentification/MuidCaloScatteringTools
• Tracking/TrkEvent/TrkTrack
• Tracking/TrkEventCnv/TrkEventTPCnv
• Tracking/TrkExtrapolation/TrkExTools
• Tracking/TrkFitter/TrkGlobalChi2Fitter
• Tracking/TrkG4Components/TrkG4UserActions
• Tracking/TrkVertexFitter/TrkVertexFitters
• graphics/VP1/VP1Systems/VP1TrackSystems

Affected files list will not be printed in this case

Adding @goetz ,@jchapman ,@rosati ,@dshope ,@wleight ,@cohm ,@stavrop ,@amorley ,@jojungge ,@egodden ,@lshan ,@rbianchi as watchers

added EventDisplay Simulation labels

added 1 commit

• ded7d604 - Run clang-tidy on migrated packages

Compare with previous version

WARNING: big files (>100K) are found in the changeset

264K in file Tracking/TrkExtrapolation/TrkExTools/src/Extrapolator.cxx

292K in file Tracking/TrkFitter/TrkGlobalChi2Fitter/src/GlobalChi2Fitter.cxx

This merge request affects 11 packages:

• HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecTools/HGTD_TrackTimeExtensionTools
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
• Reconstruction/MuonIdentification/MuidCaloEnergyTools
• Reconstruction/MuonIdentification/MuidCaloScatteringTools
• Tracking/TrkEvent/TrkTrack
• Tracking/TrkEventCnv/TrkEventTPCnv
• Tracking/TrkExtrapolation/TrkExTools
• Tracking/TrkFitter/TrkGlobalChi2Fitter
• Tracking/TrkG4Components/TrkG4UserActions
• Tracking/TrkVertexFitter/TrkVertexFitters
• graphics/VP1/VP1Systems/VP1TrackSystems

Affected files list will not be printed in this case

Adding @goetz ,@jchapman ,@rosati ,@dshope ,@wleight ,@cohm ,@stavrop ,@amorley ,@jojungge ,@egodden ,@lshan ,@rbianchi as watchers

added 1 commit

• d5bf564b - Hopefully last client

Compare with previous version

WARNING: big files (>100K) are found in the changeset

264K in file Tracking/TrkExtrapolation/TrkExTools/src/Extrapolator.cxx

292K in file Tracking/TrkFitter/TrkGlobalChi2Fitter/src/GlobalChi2Fitter.cxx

This merge request affects 12 packages:

• HighGranularityTimingDetector/HGTD_Reconstruction/HGTD_RecTools/HGTD_TrackTimeExtensionTools
• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
• Reconstruction/MuonIdentification/MuidCaloEnergyTools
• Reconstruction/MuonIdentification/MuidCaloScatteringTools
• Tracking/TrkEvent/TrkTrack
• Tracking/TrkEventCnv/TrkEventTPCnv
• Tracking/TrkExtrapolation/TrkExTools
• Tracking/TrkFitter/TrkGlobalChi2Fitter
• Tracking/TrkG4Components/TrkG4UserActions
• Tracking/TrkTruthTracks/TrkTruthTrackTools
• Tracking/TrkVertexFitter/TrkVertexFitters
• graphics/VP1/VP1Systems/VP1TrackSystems

Affected files list will not be printed in this case

Adding @goetz ,@jchapman ,@rosati ,@dshope ,@wleight ,@cohm ,@stavrop ,@amorley ,@jojungge ,@egodden ,@lshan ,@rbianchi as watchers

CI Result FAILURE (hash 66658c39)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 4, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 48816]