Skip to content
Snippets Groups Projects

Avoid range error in SCT_ClusteringTool.

All threads resolved!

The SCT strip range computed from the number of the first strip and the group size may exceed the maximum strip number. To avoid range errors the strip range is capped.

Mitigates ATLASRECTS-6892.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Goetz Gaycken added 1 commit

    added 1 commit

    • eb0e17a8 - Avoid range error in SCT_ClusteringTool.

    Compare with previous version

  • Goetz Gaycken resolved all threads

    resolved all threads

  • Author Developer

    above changes: removed compile flag modifications (debugging leftover )

  • :pencil: There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

  • This merge request affects 1 package:

    • InnerDetector/InDetRecTools/SiClusterizationTool

    This merge request affects 1 file:

    • InnerDetector/InDetRecTools/SiClusterizationTool/src/SCT_ClusteringTool.cxx

    Adding @goetz ,@amorley ,@sroe as watchers

  • :white_check_mark: CI Result SUCCESS (hash eb0e17a8)

    Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :white_check_mark: DetCommon: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 48900]

  • the code changes look fine, CI passed, approving.

    Roman(L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 767b9845

  • Please register or sign in to reply
    Loading