jet hypo more optimisation for simple trees.

The calculation of jet gruop products is avoided for simple trees. New specialised IJetProduct implementations are created that either reurn a vector of jets, or merge vectors of jets, according to the circumstances.

JetGroupProductFactory has been expanded to instantiate these new classes.

@ayana @cantel @peter @tamartin ATR-25135 recent_hypo_optimisation.pdf

added JetHLTHypo changes-derivation-output + 1 deleted label

assigned to @peter

added 1 commit

• 289a98e4 - jet hypo - add JetGroupReducer, an implementation of IJetGroupProduct in...

Compare with previous version

Hi Peter: relevant theorems appear sound (we can discuss these further offline), and my only suggestion on the code is for future maintainers-- revise your inline documentation so that the relevant definitions that make their way into function names are apparent without consulting tex/pdf files (example: define "Clique" close to where it is used, etcetera). I'm ok to undraft.

Hi Ayana,

I will undraft now. We have more work to do on non-simple trees which should occur in the very near future. I will to put in some more comments then.

marked this merge request as ready

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigHypothesis/TrigHLTJetHypoUnitTests

Affected files list will not be printed in this case

Adding @ayana ,@peter ,@valentem ,@cantel as watchers

added JetEtmiss Trigger TriggerJet master review-pending-level-1 labels

CI Result SUCCESS (hash 289a98e4)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 49035]

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 192480b0 - jet hypo. Add 'vritual' keyword to functions marked override

Compare with previous version

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigHypothesis/TrigHLTJetHypoUnitTests

Affected files list will not be printed in this case

Adding @ayana ,@peter ,@valentem ,@cantel as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 192480b0)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 49171]

added review-user-action-required label and removed review-pending-level-1 label

Hi, please resolve discussions.

Magdalena (L1)

added 525 commits

• 192480b0...437f4abf - 523 commits from branch atlas:master
• 97b08382 - Merge remote-tracking branch 'upstream/master' into master-25135-1
• f1890a08 - jet hypo add comments.

Compare with previous version

resolved all threads

This merge request affects 2 packages:

• Trigger/TrigHypothesis/TrigHLTJetHypo
• Trigger/TrigHypothesis/TrigHLTJetHypoUnitTests

Affected files list will not be printed in this case

Adding @ayana ,@peter ,@valentem ,@cantel as watchers

added review-pending-level-1 label and removed review-user-action-required label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result SUCCESS (hash f1890a08)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 49228]

the code was checked by L1 before, I also checked it and it looks fine from L1 perspective. However, given the extensive changes and new file creations, I think L2 should also take a look.

Roman(L1)

added review-pending-level-2 label and removed review-pending-level-1 label

removed review-pending-level-2 label

added review-approved label

I approved, but I suppose changes-derivation-output and changes-upgrade-output are a mistake?

Hi Tadej, I do not know how these labels were assigned. The change are optimisations - and should change no outputs. Thanks for approving. Peter

removed changes-derivation-output label

removed 1 deleted label

resolved all threads

merged

mentioned in commit 0e0cc212

added sweep:ignore label