Archive the Legacy TrkKalmanFitter. It is not MT safe or maintained.
Archive the Legacy TrkKalmanFitter implementation. IT is the only ATLAS fitter not being MT-safe or planned to become and has not be maintained for a few years
One can use
- The
ActsKalmanFitterimplementationsclass ActsKalmanFitter : virtual public Trk::ITrackFitter, public AthAlgToolor - The MT-safe HLT
DistributedKalmanimplementationclass DistributedKalmanFilter : virtual public ITrackFitter, public AthAlgTool
Merge request reports
Activity
This merge request affects 9 packages:
- InnerDetector/InDetConfig
- InnerDetector/InDetExample/InDetAlignExample
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetMonitoring/InDetPerformanceMonitoring
- Tracking/TrkFitter/TrkDynamicNoiseAdjustor
- Tracking/TrkFitter/TrkFitterInterfaces
- Tracking/TrkFitter/TrkFitterUtils
- Tracking/TrkFitter/TrkKalmanFitter
- graphics/VP1/VP1Algs
Affected files list will not be printed in this case
Adding @goetz ,@amorley ,@martis ,@sroe ,@rbianchi as watchers
added DQ EventDisplay InnerDetector Tracking master review-pending-level-1 labels
-
This merge request affects 9 packages:
- InnerDetector/InDetConfig
- InnerDetector/InDetExample/InDetAlignExample
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetMonitoring/InDetPerformanceMonitoring
- Tracking/TrkFitter/TrkDynamicNoiseAdjustor
- Tracking/TrkFitter/TrkFitterInterfaces
- Tracking/TrkFitter/TrkFitterUtils
- Tracking/TrkFitter/TrkKalmanFitter
- graphics/VP1/VP1Algs
Affected files list will not be printed in this case
Adding @goetz ,@amorley ,@martis ,@sroe ,@rbianchi as watchers
-
This merge request affects 9 packages:
- InnerDetector/InDetConfig
- InnerDetector/InDetExample/InDetAlignExample
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetMonitoring/InDetPerformanceMonitoring
- Tracking/TrkFitter/TrkDynamicNoiseAdjustor
- Tracking/TrkFitter/TrkFitterInterfaces
- Tracking/TrkFitter/TrkFitterUtils
- Tracking/TrkFitter/TrkKalmanFitter
- graphics/VP1/VP1Algs
Affected files list will not be printed in this case
Adding @goetz ,@amorley ,@martis ,@sroe ,@rbianchi as watchers
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals 
cmake make 
required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make 
required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Hi @christos,
there are two issues to be addressed in the compilation, see error messages below.
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/TrkValidation/TrkValTools/src/DirectTrackNtupleWriterTool.cxx:22:10: fatal error: TrkFitterUtils/ProtoTrackStateOnSurface.h: No such file or directory 22 | #include "TrkFitterUtils/ProtoTrackStateOnSurface.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/InnerDetector/InDetExample/InDetRecExample/python/InDetRecExampleConfig.py:3:1: warning: F401 'AthenaCommon.CfgGetter' imported but unused from AthenaCommon import CfgGetter ^ /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/InnerDetector/InDetExample/InDetRecExample/python/InDetRecExampleConfig.py:13:9: warning: F811 redefinition of unused 'CfgGetter' from line 3 from AthenaCommon import CfgGetter ^Jakub (L1 shifter)
added review-user-action-required label and removed review-pending-level-1 label
-
This merge request affects 12 packages:
- InnerDetector/InDetConfig
- InnerDetector/InDetExample/InDetAlignExample
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetMonitoring/InDetPerformanceMonitoring
- InnerDetector/InDetRecTools/InDetDNASeparator
- Tracking/TrkFitter/TrkDynamicNoiseAdjustor
- Tracking/TrkFitter/TrkFitterInterfaces
- Tracking/TrkFitter/TrkFitterUtils
- Tracking/TrkFitter/TrkKalmanFitter
- Tracking/TrkValidation/TrkValInterfaces
- Tracking/TrkValidation/TrkValTools
- graphics/VP1/VP1Algs
Affected files list will not be printed in this case
Adding @goetz ,@amorley ,@martis ,@sroe ,@rbianchi as watchers
added JetEtmiss review-pending-level-1 labels and removed review-user-action-required label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added full-build full-unit-tests labels
I am adding the full labels as I am removing quite a few things. After discussing with @akraszna seems the "safe" thing to do
Edited by Christos Anastopoulosadded 65 commits
-
448132f1...f746d34e - 64 commits from branch
atlas:master - 8bc79fe2 - merge upstream
-
448132f1...f746d34e - 64 commits from branch
-
This merge request affects 11 packages:
- InnerDetector/InDetExample/InDetAlignExample
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetMonitoring/InDetPerformanceMonitoring
- InnerDetector/InDetRecTools/InDetDNASeparator
- Tracking/TrkFitter/TrkDynamicNoiseAdjustor
- Tracking/TrkFitter/TrkFitterInterfaces
- Tracking/TrkFitter/TrkFitterUtils
- Tracking/TrkFitter/TrkKalmanFitter
- Tracking/TrkValidation/TrkValInterfaces
- Tracking/TrkValidation/TrkValTools
- graphics/VP1/VP1Algs
Affected files list will not be printed in this case
Adding @goetz ,@amorley ,@martis ,@sroe ,@rbianchi as watchers
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
-
Hmmm
2022-04-06 03:07:44,376 electronInViewAlgs_LRT FATAL Exception with tag=TrigFastTrackFinder__electronLRT is caught 2022-Apr-06 03:07:44,376 FATAL [ at electronInViewAlgs_LRT:1205748223] electronInViewAlgs_LRT: Exception with tag=TrigFastTrackFinder__electronLRT is caught 2022-04-06 03:07:44,376 electronInViewAlgs_LRT ERROR TrigFastTrackFinder__electronLRT Failed to retrieve tool Trk::KalmanFitter/InDetTrackFitter StatusCode=FAILURE 2022-Apr-06 03:07:44,376 ERROR [ at electronInViewAlgs_LRT:2058270728] electronInViewAlgs_LRT: TrigFastTrackFinder__electronLRT Failed to retrieve tool Trk::KalmanFitter/InDetTrackFitter StatusCode=FAILURE 2022-04-06 03:07:44,376 electronInViewAlgs_LRT ERROR AthenaBaseComps/AthenaBaseComps/AthCommonDataStore.icc:43 (StatusCode AthCommonDataStore<PBASE>::sysInitialize() [with PBASE = AthCommonMsg<Gaudi::Sequence>]): code FAILURE: PBASE::sysInitialize()@sutt, @jmasik ,@tamartin I had the impression we do really use that, but only the MT safe fitters
m_disTrkFitter("Trk::KalmanFitter/InDetTrackFitter"),but this must be a "default" I assumed the actual one should be whatever the
InDetTrigFlags.trackFitterType()say it should be.I am drafting this one. But if is really used I would assume we might be in MT trouble here ... I assume some chains leave the default on rather than Chi2 or the HLT distributed Kalman ? I double this Kalman was meant to be "default" even ... I assumed this was the Chi2
0471 class trackFitterType(InDetFlagsJobProperty): 0472 """ control which fitter to be used: 'KalmanFitter', 'KalmanDNAFitter', 'DistributedKalmanFilter', 'GlobalChi2Fitter', 'GaussianSumFilter' """ 0473 statusOn = True 0474 allowedTypes = ['str'] 0475 allowedValues= ['KalmanFitter', 'KalmanDNAFitter', 'DistributedKalmanFilter', 'GlobalChi2Fitter', 'GaussianSumFilter', 'ReferenceKalmanFitter'] 0476 StoredValue = 'GlobalChi2Fitter'The issue is not "keeping" it for a bit more, that would be fine, the issue is that is the one not ever be checked for MT safety, with mutable, and not sure who maintains it the last few years. And was convinced the HLT uses a different default here. (chi2 or distributedKalman which is HLT oriented and MT safe)
Edited by Christos Anastopoulos -
OK
good to know is used only for special cases ... and is a relatively new feature as could not undrstand how/when it enters ...
Anyhow, I think is not the 1st time and prb you all know it . But fitters checked to be thread safe
- Chi2
- Distributed Kalman
- iPat
- GSF
- TrigInDetTrackFitter
Not checked to be thread safe and not sure on if is maintained at all (pretty sure is not at the moment)
- TrkKalmanFitter
At least if is used in MT we should check things make sense there. Try to at least pass the basic checker. I was not expecting a non-MT fitter to be used in production without anyone having tried to make it thread safe but maybe I miss something .
I hope @nagano can comment, I recall this being mentioned in a JIRA in the long past also but do not recall the outcome.
Edited by Christos Anastopoulos removed full-unit-tests label
-
In the meantime will try to "fix it"
0281 // UTT tools 0282 if( m_doDisappearingTrk ) { 0283 ATH_CHECK(m_extrapolator.retrieve()); 0284 ATH_MSG_DEBUG("Retrieved tool " << m_extrapolator); 0285 0286 ATH_CHECK(m_disTrkFitter.retrieve()); 0287 ATH_MSG_DEBUG("Retrieved tool " << m_disTrkFitter); 0288 }in master one should call disable explicitly . Which prb explains the number of FATAL here ... even if m_doDisappearingTrk master will retrieve defaults which makes everything fail ... so lets see if now we can pass the tests
Edited by Christos Anastopoulos -
This merge request affects 12 packages:
- InnerDetector/InDetExample/InDetAlignExample
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetMonitoring/InDetPerformanceMonitoring
- InnerDetector/InDetRecTools/InDetDNASeparator
- Tracking/TrkFitter/TrkDynamicNoiseAdjustor
- Tracking/TrkFitter/TrkFitterInterfaces
- Tracking/TrkFitter/TrkFitterUtils
- Tracking/TrkFitter/TrkKalmanFitter
- Tracking/TrkValidation/TrkValInterfaces
- Tracking/TrkValidation/TrkValTools
- Trigger/TrigAlgorithms/TrigFastTrackFinder
- graphics/VP1/VP1Algs
Affected files list will not be printed in this case
Adding @goetz ,@amorley ,@martis ,@sroe ,@nagano ,@rbianchi as watchers
added Trigger TriggerID labels and removed review-pending-level-1 label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make required tests optional tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added full-unit-tests label
-
This merge request affects 12 packages:
- InnerDetector/InDetExample/InDetAlignExample
- InnerDetector/InDetExample/InDetRecExample
- InnerDetector/InDetMonitoring/InDetPerformanceMonitoring
- InnerDetector/InDetRecTools/InDetDNASeparator
- Tracking/TrkFitter/TrkDynamicNoiseAdjustor
- Tracking/TrkFitter/TrkFitterInterfaces
- Tracking/TrkFitter/TrkFitterUtils
- Tracking/TrkFitter/TrkKalmanFitter
- Tracking/TrkValidation/TrkValInterfaces
- Tracking/TrkValidation/TrkValTools
- Trigger/TrigAlgorithms/TrigFastTrackFinder
- graphics/VP1/VP1Algs
Affected files list will not be printed in this case
Adding @goetz ,@amorley ,@martis ,@sroe ,@nagano ,@rbianchi as watchers
added review-pending-level-1 label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis DetCommon externals cmake make N/A N/A N/A N/A N/A N/A required tests N/A N/A N/A N/A N/A N/A optional tests N/A N/A N/A N/A N/A N/A 
